Api 26640 establish 526 claim #12907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add serviceInformation Map date
And 3 open questions
acovrig
commented
Jun 6, 2023
Comment on lines
+31
to
+32
| # evss_data = evss_mapper_service(auto_claim).map_claim | ||
| # evss_claim = evss_service.submit(auto_claim, evss_data) |
There was a problem hiding this comment.
I'm leaving these commented out for now since the container itself seems flaky, I don't want another dev to get stuck trying to figure out why this endpoint doesn't work sometimes.
acovrig
commented
Jun 6, 2023
| secondary.except(:exposureOrEventOrInjury, :approximateDate) | ||
| end | ||
|
|
||
| disability[:specialIssues] = 'PACT' if disability[:isRelatedToToxicExposure] |
There was a problem hiding this comment.
I'm not 💯 on this one, sometimes they complain about it, sometimes they don't, so this may need to be something else (I.E. ['PACT'] or {code: 'PACT', name: 'PACT'})
va-vfs-bot
temporarily deployed
to
API-26640-establish-526-claim/main/main
stiehlrod
reviewed
Jun 7, 2023
modules/claims_api/lib/claims_api/v2/disability_compensation_evss_mapper.rb
Show resolved
Hide resolved
stiehlrod
reviewed
Jun 7, 2023
|
|
||
| def change_of_address | ||
| return if @data[:changeOfAddress].blank? | ||
|
|
There was a problem hiding this comment.
Looking at https://jira.devops.va.gov/browse/API-26640 it looks like we only need veteranIdentification, not ChangeOfAddress.
stiehlrod
reviewed
Jun 7, 2023
modules/claims_api/lib/claims_api/v2/disability_compensation_evss_mapper.rb
Show resolved
Hide resolved
It seems PACT isn't a valid value, though...
va-vsp-bot
requested a deployment
to
API-26640-establish-526-claim/main/main
va-vfs-bot
temporarily deployed
to
API-26640-establish-526-claim/main/main
va-vsp-bot
requested a deployment
to
API-26640-establish-526-claim/main/main
va-vsp-bot
requested a deployment
to
API-26640-establish-526-claim/main/main
va-vfs-bot
temporarily deployed
to
API-26640-establish-526-claim/main/main
va-vfs-bot
temporarily deployed
to
API-26640-establish-526-claim/main/main
va-vsp-bot
requested a deployment
to
API-26640-establish-526-claim/main/main
va-vfs-bot
temporarily deployed
to
API-26640-establish-526-claim/main/main
va-vsp-bot
requested a deployment
to
API-26640-establish-526-claim/main/main
va-vfs-bot
temporarily deployed
to
API-26640-establish-526-claim/main/main
va-vsp-bot
requested a deployment
to
API-26640-establish-526-claim/main/main
va-vfs-bot
temporarily deployed
to
API-26640-establish-526-claim/main/main
va-vsp-bot
requested a deployment
to
API-26640-establish-526-claim/main/main
va-vsp-bot
requested a deployment
to
API-26640-establish-526-claim/main/main
va-vfs-bot
temporarily deployed
to
API-26640-establish-526-claim/main/main
stiehlrod
approved these changes
Jun 13, 2023
ryan-mcneil
pushed a commit
that referenced
this pull request
Dec 11, 2023
Finally got the mapper working mostly - PACT mapping still needs done, but got moved to another ticket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Testing done
rspecWhat areas of the site does it impact?
Claims V2 526 submission
Acceptance criteria