Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

59701 Change how we represent UK addresses #12911

Merged
merged 0 commits into from
Jun 9, 2023

Conversation

data-doge
Copy link
Contributor

@data-doge data-doge commented Jun 6, 2023

Summary

Change how we represent UK addresses to BIS

Before this PR, if the veteran provided an international_postal_code (i.e. GBR), we used an IsoCountryCodes class to automatically expand that to "United Kingdom of Great Britain and Northern Ireland", which exceeds BIS's 50 character limit for countries by two characters. No other country exceeds the 50 character limit. BIS told me that they use "United Kingdom" for the UK. This PR adds in that exception, along with some minor refactoring.

I am on the benefits decision reviews team, which is currently responsible for the 686c form.

Related issue(s)

department-of-veterans-affairs/va.gov-team#59701

Testing done

Added unit tests. Will monitor DataDog to verify that UK-related errors disappear.

Screenshots

What areas of the site does it impact?

686c form.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

N/A

@va-vfs-bot va-vfs-bot temporarily deployed to 59701-change-how-we-represent-uk-addresses/main/main June 6, 2023 19:18 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 59701-change-how-we-represent-uk-addresses/main/main June 6, 2023 20:26 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 59701-change-how-we-represent-uk-addresses/main/main June 6, 2023 20:46 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 59701-change-how-we-represent-uk-addresses/main/main June 7, 2023 15:34 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 59701-change-how-we-represent-uk-addresses/main/main June 7, 2023 15:42 Inactive
@data-doge data-doge force-pushed the 59701-change-how-we-represent-uk-addresses branch from fc7a77b to bb8e62a Compare June 7, 2023 15:51
@va-vsp-bot va-vsp-bot requested a deployment to 59701-change-how-we-represent-uk-addresses/main/main June 7, 2023 15:51 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 59701-change-how-we-represent-uk-addresses/main/main June 7, 2023 15:57 Inactive
@data-doge data-doge marked this pull request as ready for review June 7, 2023 16:03
@data-doge data-doge requested review from a team as code owners June 7, 2023 16:03
@data-doge data-doge enabled auto-merge (squash) June 7, 2023 16:03
@data-doge data-doge self-assigned this Jun 7, 2023
@va-vsp-bot va-vsp-bot requested a deployment to 59701-change-how-we-represent-uk-addresses/main/main June 8, 2023 15:24 In progress
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Please note that going forward we'll be a bit more pushy about getting reviews done by members of your own team first, as we don't necessarily have the context to confirm that changes appropriately respect the business needs of the ticket. Without it, we have to spend considerably more time looking at the changes (like today's, which can easily get disrupted by higher priority things). We're mostly here to make sure nothing looks too scary or lacks tests, is appropriately using secrets/param store, etc. Thanks in advance!

@data-doge data-doge merged commit cb9d9cd into master Jun 9, 2023
@data-doge data-doge deleted the 59701-change-how-we-represent-uk-addresses branch June 9, 2023 17:16
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
Before this PR, if the veteran provided an `international_postal_code` (i.e. GBR), we used an `IsoCountryCodes` class to automatically expand that to "United Kingdom of Great Britain and Northern Ireland", which exceeds BIS's 50 character limit for countries by two characters.  No other country exceeds the 50 character limit.  BIS told me that they use "United Kingdom" for the UK.  This PR adds in that exception, along with some minor refactoring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants