59701 Change how we represent UK addresses #12911
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change how we represent UK addresses to BIS
Before this PR, if the veteran provided an
international_postal_code
(i.e. GBR), we used anIsoCountryCodes
class to automatically expand that to "United Kingdom of Great Britain and Northern Ireland", which exceeds BIS's 50 character limit for countries by two characters. No other country exceeds the 50 character limit. BIS told me that they use "United Kingdom" for the UK. This PR adds in that exception, along with some minor refactoring.I am on the benefits decision reviews team, which is currently responsible for the 686c form.
Related issue(s)
department-of-veterans-affairs/va.gov-team#59701
Testing done
Added unit tests. Will monitor DataDog to verify that UK-related errors disappear.
Screenshots
What areas of the site does it impact?
686c form.
Acceptance criteria
Requested Feedback
N/A