Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict copay statement notifications to 1000 / minute #12924

Merged
merged 0 commits into from
Jun 7, 2023

Conversation

ScottyRJames
Copy link
Contributor

Summary

  • VA Notify has requested our service to restrict api traffic requests for these notifications to 1000 / minute

@ScottyRJames ScottyRJames requested review from a team as code owners June 7, 2023 16:36
@va-vfs-bot va-vfs-bot temporarily deployed to rate-limit-copay-notifications/main/main June 7, 2023 16:38 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to rate-limit-copay-notifications/main/main June 7, 2023 16:57 In progress
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@ScottyRJames ScottyRJames merged commit 3fe7b94 into master Jun 7, 2023
@ScottyRJames ScottyRJames deleted the rate-limit-copay-notifications branch June 7, 2023 17:29
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
* Add limiter for batch processing

* Adjust limit numbers

* Move to concurrent approach

* Break out from batch

* Decrease concurrent thread count

* Revert past decrease

* Move throttle to class method

* Make static limiter

* Lint

* Lint pt 2

* Restrict copay notifications to 1000/minute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants