Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Update appointments to use VAOS for local time #12933

Merged
merged 0 commits into from
Jun 9, 2023

Conversation

Tonksthebear
Copy link
Contributor

Summary

VAOS now provides the converted local time, so this ticket migrates mobile to use this new field

Related issue(s)

Testing done

Existing test coverage should handle the changes

What areas of the site does it impact?

Mobile appointments endpoint

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@github-actions github-actions bot added the mobile label Jun 8, 2023
@va-vfs-bot va-vfs-bot temporarily deployed to vaos_local_time/main/main June 8, 2023 18:15 Inactive
@Tonksthebear Tonksthebear marked this pull request as ready for review June 8, 2023 19:19
@Tonksthebear Tonksthebear requested review from a team as code owners June 8, 2023 19:19
@va-vsp-bot va-vsp-bot requested a deployment to vaos_local_time/main/main June 8, 2023 19:19 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to vaos_local_time/main/main June 8, 2023 19:21 Inactive
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Contributor

@kpethtel kpethtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Any tests for the new case?

@Tonksthebear
Copy link
Contributor Author

Looks good. Any tests for the new case?

The existing tests should cover it I believe. The existing tests already hit cases where VAOS would return nil or the error message in start_local_time so they hit the fallback code as is

@Tonksthebear Tonksthebear merged commit 6235994 into master Jun 9, 2023
@Tonksthebear Tonksthebear deleted the vaos_local_time branch June 9, 2023 16:47
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
* WIP

* Maintain mobile fallback in the event vaos does not return a local time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants