Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

59960 Truncate travel claim number to last4 #12936

Merged
merged 0 commits into from
Jun 9, 2023

Conversation

randomsync
Copy link
Member

@randomsync randomsync commented Jun 8, 2023

Summary

This PR truncates the travel claim number to last 4 since we don't want to send any PII/PHI data in text notifications.

team: check-in experience

Related issue(s)

Testing done

  • rspecs
  • local testing
  • staging testing

What areas of the site does it impact?

  • check-in experience text notification for travel claims

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to 59960_travel_claim_last4/main/main June 8, 2023 20:49 Inactive
@randomsync randomsync marked this pull request as ready for review June 9, 2023 16:35
@randomsync randomsync requested review from a team as code owners June 9, 2023 16:35
@va-vsp-bot va-vsp-bot requested a deployment to 59960_travel_claim_last4/main/main June 9, 2023 16:36 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 59960_travel_claim_last4/main/main June 9, 2023 16:36 Inactive
Copy link
Contributor

@brianseek brianseek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@lee-delarm6 lee-delarm6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good here, clean work!

@lee-delarm6 lee-delarm6 merged commit 8da7f8a into master Jun 9, 2023
@lee-delarm6 lee-delarm6 deleted the 59960_travel_claim_last4 branch June 9, 2023 16:53
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants