Move copay notifications back to concurrent approach #12938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
revert-to-concurrent-limiter/main/main
va-vsp-bot
requested a deployment
to
revert-to-concurrent-limiter/main/main
va-vsp-bot
requested a deployment
to
revert-to-concurrent-limiter/main/main
va-vfs-bot
temporarily deployed
to
revert-to-concurrent-limiter/main/main
va-vsp-bot
requested a deployment
to
revert-to-concurrent-limiter/main/main
va-vfs-bot
temporarily deployed
to
revert-to-concurrent-limiter/main/main
jeremy6d
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
I know this is a small change but in the future it would help us expedite if we had more explication in the description, at least a link to a ticket that directs this work and lays out the acceptance criteria. It would also give us a lot more confidence to get a review from one of your teammates or project-adjacent peers, as we don't have the context for the work you're doing like they do. Thanks!
|
Thanks @jeremy6d, the other BE engineer on my team is out of office currently but I'll be sure to provide more context in future PRs |
ryan-mcneil
pushed a commit
that referenced
this pull request
Dec 11, 2023
* Move back to concurrent approach... * Decrease to 4 workers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary