Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OAS content claims v1, add swagger #12943

Merged
merged 0 commits into from
Jun 12, 2023

Conversation

mchristiansonVA
Copy link
Contributor

Summary

  • Updates OAS content for claims v1 per request from UI team.

Related issue(s)

API-26922

Testing done

  • Tested locally to confirm updated content appears as expected.

What areas of the site does it impact?

OAS claims v1 documentation, as updated in the following files:
modules/claims_api/app/swagger/claims_api/description/v1.md
modules/claims_api/app/swagger/claims_api/v1/swagger.json

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mchristiansonVA mchristiansonVA merged commit 2dc6ac6 into master Jun 12, 2023
@mchristiansonVA mchristiansonVA deleted the API-26922_OAS_Updates_Claims_v1 branch June 12, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api Lighthouse lighthouse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants