Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API-26667-Add-evss-flipper-feature #12946

Merged
merged 0 commits into from
Jun 12, 2023
Merged

API-26667-Add-evss-flipper-feature #12946

merged 0 commits into from
Jun 12, 2023

Conversation

stiehlrod
Copy link
Contributor

Summary

  • Adds flipper feature for retrieving claim status information directly from BGS in our v1 claim status services

Related issue(s)

Testing done

  • rspec
  • setup, nothing to test yet

What areas of the site does it impact?

config/features.yml

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@stiehlrod stiehlrod added Lighthouse lighthouse claimsApi modules/claims_api labels Jun 9, 2023
@va-vfs-bot va-vfs-bot temporarily deployed to API-26667-Add-evss-flipper-feature/main/main June 9, 2023 16:20 Inactive
@stiehlrod stiehlrod marked this pull request as ready for review June 12, 2023 13:44
@stiehlrod stiehlrod requested review from a team as code owners June 12, 2023 13:44
FonzMP
FonzMP approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@FonzMP FonzMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@va-vsp-bot va-vsp-bot requested a deployment to API-26667-Add-evss-flipper-feature/main/main June 12, 2023 21:43 In progress
@stiehlrod stiehlrod enabled auto-merge (squash) June 12, 2023 21:43
@stiehlrod stiehlrod merged commit d557682 into master Jun 12, 2023
@stiehlrod stiehlrod deleted the API-26667-Add-evss-flipper-feature branch June 12, 2023 21:50
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
@stiehlrod
Adds flipper feature for evss switch to bgs (#12946)
6d75042
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FonzMP FonzMP FonzMP approved these changes

Assignees
No one assigned
Labels
claimsApi modules/claims_api console-services-review Lighthouse lighthouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stiehlrod @FonzMP @va-vfs-bot @va-vsp-bot