Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api 27078 526 v2 allow yyyy mm date format 2 #12957

Merged

Conversation

rockwellwindsor-va
Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va commented Jun 12, 2023

Adds the ability to submit approximate date values with only month and year, so that the Veteran can provide an approximate date.

This is reverting the revert on this branch done on 6/09 This branch was found to not be the cause of the issue after reverting it so this is a revert of the revert.

Summary

  • Updates 526.json and related json files to be inline with new date formats
  • Updates validations file to handle new date formats
  • Updates validation specs t handle tests with new date formats
  • Also adds some new tests for handling new scenarios
  • Updates swagger docs

Related issue(s)

API-27078

Testing done

  • RSpec

What areas of the site does it impact?

modified: modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb
modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
modified: modules/claims_api/config/schemas/v2/526.json
modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/example.json
modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json
modified: modules/claims_api/spec/fixtures/v2/veterans/disability_compensation/form_526_json_api.json
modified: modules/claims_api/spec/lib/claims_api/v2/disability_compensation_pdf_mapper_spec.rb
modified: modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb
modified: spec/support/schemas/claims_api/v2/forms/disability/submission.json

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@github-actions
Copy link

github-actions bot commented Jun 12, 2023

1 Warning
⚠️ This PR changes 340 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb (+54/-5)

  • modules/claims_api/spec/lib/claims_api/v2/disability_compensation_pdf_mapper_spec.rb (+13/-13)

  • modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb (+238/-17)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vsp-bot va-vsp-bot requested a deployment to API-27078-526-v2-allow-yyyy-mm-date-format-2/main/main June 12, 2023 12:57 In progress
@va-vsp-bot va-vsp-bot requested a deployment to API-27078-526-v2-allow-yyyy-mm-date-format-2/main/main June 12, 2023 13:10 In progress
@rockwellwindsor-va rockwellwindsor-va added the claimsApi modules/claims_api label Jun 12, 2023
@va-vsp-bot va-vsp-bot requested a deployment to API-27078-526-v2-allow-yyyy-mm-date-format-2/main/main June 12, 2023 13:19 In progress
@rockwellwindsor-va rockwellwindsor-va marked this pull request as ready for review June 12, 2023 13:41
@rockwellwindsor-va rockwellwindsor-va requested review from a team as code owners June 12, 2023 13:41
@rockwellwindsor-va rockwellwindsor-va marked this pull request as draft June 12, 2023 18:25
@va-vsp-bot va-vsp-bot requested a deployment to API-27078-526-v2-allow-yyyy-mm-date-format-2/main/main June 12, 2023 18:25 In progress
@va-vsp-bot va-vsp-bot requested a deployment to API-27078-526-v2-allow-yyyy-mm-date-format-2/main/main June 12, 2023 19:37 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-27078-526-v2-allow-yyyy-mm-date-format-2/main/main June 12, 2023 19:50 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-27078-526-v2-allow-yyyy-mm-date-format-2/main/main June 12, 2023 20:58 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-27078-526-v2-allow-yyyy-mm-date-format-2/main/main June 12, 2023 21:06 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-27078-526-v2-allow-yyyy-mm-date-format-2/main/main June 12, 2023 21:13 In progress
@rockwellwindsor-va rockwellwindsor-va marked this pull request as ready for review June 12, 2023 21:22
@va-vfs-bot va-vfs-bot temporarily deployed to API-27078-526-v2-allow-yyyy-mm-date-format-2/main/main June 12, 2023 21:28 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-27078-526-v2-allow-yyyy-mm-date-format-2/main/main June 12, 2023 21:56 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-27078-526-v2-allow-yyyy-mm-date-format-2/main/main June 12, 2023 22:00 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-27078-526-v2-allow-yyyy-mm-date-format-2/main/main June 13, 2023 13:47 In progress
@rockwellwindsor-va rockwellwindsor-va marked this pull request as draft June 13, 2023 13:50
@va-vfs-bot va-vfs-bot temporarily deployed to API-27078-526-v2-allow-yyyy-mm-date-format-2/main/main June 13, 2023 13:54 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-27078-526-v2-allow-yyyy-mm-date-format-2/main/main June 13, 2023 14:16 In progress
@va-vsp-bot va-vsp-bot requested a deployment to API-27078-526-v2-allow-yyyy-mm-date-format-2/main/main June 13, 2023 14:18 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-27078-526-v2-allow-yyyy-mm-date-format-2/main/main June 13, 2023 14:19 Inactive
Copy link
Contributor

@mchristiansonVA mchristiansonVA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@va-vsp-bot va-vsp-bot requested a deployment to API-27078-526-v2-allow-yyyy-mm-date-format-2/main/main June 13, 2023 14:30 In progress
@rockwellwindsor-va rockwellwindsor-va marked this pull request as ready for review June 13, 2023 14:31
@rockwellwindsor-va rockwellwindsor-va merged commit 4c43ff8 into master Jun 13, 2023
@rockwellwindsor-va rockwellwindsor-va deleted the API-27078-526-v2-allow-yyyy-mm-date-format-2 branch June 13, 2023 14:40
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
* API-27078-526-v2-allow-yyyy-mm-date-format-2

* Updates 526.json and related json fles to be inline with new date formats
* Updates valdations file to handle new date formats
* Updates validation specs t handle tests with new date formats
	* Also adds some new tests for handling new scenarios
* Updates swagger docs
Changes to be committed:
	modified:   modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb
	modified:   modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
	modified:   modules/claims_api/config/schemas/v2/526.json
	modified:   modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/example.json
	modified:   modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json
	modified:   modules/claims_api/spec/fixtures/v2/veterans/disability_compensation/form_526_json_api.json
	modified:   modules/claims_api/spec/lib/claims_api/v2/disability_compensation_pdf_mapper_spec.rb
	modified:   modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb
	modified:   spec/support/schemas/claims_api/v2/forms/disability/submission.json

* Merges master and updates swagger file to make sure it is inline with these changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants