Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update disabilityActionType enum values, add swagger #12958

Merged
merged 0 commits into from
Jun 13, 2023

Conversation

mchristiansonVA
Copy link
Contributor

Summary

  • Updates disabilityActionType enum values to remove "Secondary" value from primary disabilities enumeration in schema documentation.

Related issue(s)

API-27326

Testing done

Tested locally to confirm updated content appears as expected.

What areas of the site does it impact?

Claims v2 526 documentation, as updated in the following files:
modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
modules/claims_api/config/schemas/v2/526.json
modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@mchristiansonVA mchristiansonVA added Lighthouse lighthouse claimsApi modules/claims_api labels Jun 12, 2023
@mchristiansonVA mchristiansonVA self-assigned this Jun 12, 2023
@mchristiansonVA mchristiansonVA requested review from a team as code owners June 12, 2023 14:28
@va-vfs-bot va-vfs-bot temporarily deployed to API-27326_disabilityActionType_update/main/main June 12, 2023 14:29 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-27326_disabilityActionType_update/main/main June 12, 2023 21:18 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-27326_disabilityActionType_update/main/main June 12, 2023 21:28 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-27326_disabilityActionType_update/main/main June 13, 2023 13:18 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-27326_disabilityActionType_update/main/main June 13, 2023 13:19 Inactive
@mchristiansonVA mchristiansonVA merged commit b0716ee into master Jun 13, 2023
@mchristiansonVA mchristiansonVA deleted the API-27326_disabilityActionType_update branch June 13, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api Lighthouse lighthouse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants