Api 26837/shared schema updates for appeals #12961
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two updates to help bring appeals APIs in line with Lighthouse standards:
non_blank_string
schema has been renamed tononBlankString
. Initially we had renamed this in the opposite direction, because we were using underscores in the URLs and trying to be consistent with that. But now that we're complying with standards, I've renamed this back to its original name. I did this because although there's no specificnonBlankString
guidance in the standards, they say that field names in general should be in camelCase (naming standard)en-US
Content-Language header (headers standard)There are more changes to come for this ticket, but I figured this was enough for one PR
Related issue(s)
Testing done
What areas of the site does it impact?
Acceptance criteria