Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed claims service and configuration files #12965

Merged
merged 0 commits into from
Jun 13, 2023

Conversation

cadibemma
Copy link
Contributor

Summary

  • All VA.gov apis can share credentials. This PR removes unused code that used these separate credentials in mobile claims

Related issue(s)

Testing done

  • None

What areas of the site does it impact?

  • None

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@cadibemma cadibemma requested review from a team as code owners June 12, 2023 18:15
@va-vfs-bot va-vfs-bot temporarily deployed to 5732-remove-unused-mobile-claims-service-code/main/main June 12, 2023 18:20 Inactive
Copy link
Contributor

@kpethtel kpethtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aherzberg Should this ticket also include removal of the keys from the config file? What about all of the key related changes in the devops and manifest repos?

@va-vfs-bot va-vfs-bot temporarily deployed to 5732-remove-unused-mobile-claims-service-code/main/main June 13, 2023 13:14 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 5732-remove-unused-mobile-claims-service-code/main/main June 13, 2023 15:14 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 5732-remove-unused-mobile-claims-service-code/main/main June 13, 2023 15:27 Inactive
@aherzberg
Copy link
Contributor

aherzberg commented Jun 13, 2023

@kpethtel Im hesitant to remove stuff from the devops and manifests so soon on the off chance LH changes their mind again or if we end up integrating with some other LH CCG endpoint in the future (we could just ask LH to change the permissions allowed that key) that we are the only ones integrating with. It may not be best practice to leave code unused there but it's such a hassle to put in and remove, I don't want to do it again.

Copy link
Contributor

@aherzberg aherzberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I could go either way on removing the key from the config file within vets-api. If we keep whats in devops and manifests, may want to be consistent and keep it here too. but either way, much easier to remove and put in.

Copy link
Contributor

@kpethtel kpethtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what @aherzberg is saying makes sense. We should probably just put another ticket in our backlog to remove those keys later.

@cadibemma cadibemma merged commit 93ece3e into master Jun 13, 2023
@cadibemma cadibemma deleted the 5732-remove-unused-mobile-claims-service-code branch June 13, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants