-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed claims service and configuration files #12965
removed claims service and configuration files #12965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aherzberg Should this ticket also include removal of the keys from the config file? What about all of the key related changes in the devops and manifest repos?
@kpethtel Im hesitant to remove stuff from the devops and manifests so soon on the off chance LH changes their mind again or if we end up integrating with some other LH CCG endpoint in the future (we could just ask LH to change the permissions allowed that key) that we are the only ones integrating with. It may not be best practice to leave code unused there but it's such a hassle to put in and remove, I don't want to do it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I could go either way on removing the key from the config file within vets-api. If we keep whats in devops and manifests, may want to be consistent and keep it here too. but either way, much easier to remove and put in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what @aherzberg is saying makes sense. We should probably just put another ticket in our backlog to remove those keys later.
Summary
Related issue(s)
Testing done
What areas of the site does it impact?
Acceptance criteria