API-27105: Reinstate Sidekiq Jobs Lost in Periodic Jobs Migration

[kristen-brown]

Summary

Initially my team noticed that our jobs that had been scheduled to run in the "America/New_York" time zone were now running as UTC instead. That time zone issue has since been resolved in another PR, but when investigating this issue, I noticed that the following jobs that my team owns had been removed entirely from the schedule:

• VBADocuments::ReportUnsuccessfulSubmissions
• VBADocuments::FlipperStatusAlert
• VAForms::FlipperStatusAlert

This PR reinstates those jobs listed above, and also moves the final job that my team owns, AppealsApi::HigherLevelReviewCleanUpWeekOldPii, from config/sidekiq_scheduler.yml to lib/periodic_jobs.rb. A previous PR comment had mentioned that the specs would fail if it was moved, but the specs have been running successfully locally and in CI.

AppealsApi, VBADocuments, and VAForms jobs have been grouped into their own sections so that they can be more easily found in lib/periodic_jobs.rb. In addition, instances of "MON-FRI" in the cron statements have been replaced with "1-5" to stay consistent with the other jobs in the file. Where job descriptions were missing, they have now been added.

Related issue(s)

API-27105

Testing done

The schedule has been spot-checked twice against the original (pre-periodic jobs migration) contents of config/sidekiq_scheduler.yml.

Screenshots

None

What areas of the site does it impact?

This PR impacts the periodic job schedules for AppealsApi, VBADocuments, and VAForms, all of which my team owns.

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable). – N/A
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution – N/A
• Documentation has been updated (link to documentation) – N/A
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable) – N/A
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected – N/A
• I added a screenshot of the developed feature – N/A

Requested Feedback

No specific feedback requested for this PR.

[mathisto]

APPROVED