Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service description for /veterans/{veteranId}/526 #12971

Merged

Conversation

rockwellwindsor-va
Copy link
Contributor

Add service description for /veterans/{veteranId}/526.

Summary

  • Updates description in rswag_disability_compensation_request_spec.rb
  • Updates docs for dev v2

Related issue(s)

API-22656

Testing done

Update docs and view

Screenshots

Screenshot 2023-06-12 at 5 17 59 PM

What areas of the site does it impact?

modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
modified: modules/claims_api/spec/requests/v2/veterans/rswag_disability_compensation_request_spec.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@rockwellwindsor-va rockwellwindsor-va merged commit 1fef9b7 into master Jun 13, 2023
@rockwellwindsor-va rockwellwindsor-va deleted the API-22656-526-v2-service-description-for-526-2 branch June 13, 2023 13:50
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
* Updates swagger docs for dev v2
Changes to be committed:
	modified:   modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
	modified:   modules/claims_api/spec/requests/v2/veterans/rswag_disability_compensation_request_spec.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants