Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-22655 526 v2 service description for validate endpoint #12972

Merged

Conversation

rockwellwindsor-va
Copy link
Contributor

Adds service description for /veterans/{veteranId}/526/validate endpoint

Summary

  • Updates rswag_disability_compensation_request_spec for validate endpoint edscription
  • compiles docs for v2 dev

Related issue(s)

API-22655

Testing done

  • Compiled deocs and viewed for v2 dev

Screenshots

Screenshot 2023-06-12 at 5 37 24 PM

What areas of the site does it impact?

modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
modified: modules/claims_api/spec/requests/v2/veterans/rswag_disability_compensation_request_spec.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vsp-bot va-vsp-bot requested a deployment to API-22655-526-v2-service-description-for-validate-2/main/main June 12, 2023 22:41 In progress
@rockwellwindsor-va rockwellwindsor-va added the claimsApi modules/claims_api label Jun 12, 2023
@rockwellwindsor-va rockwellwindsor-va marked this pull request as ready for review June 12, 2023 23:03
@rockwellwindsor-va rockwellwindsor-va requested review from a team as code owners June 12, 2023 23:03
@rockwellwindsor-va rockwellwindsor-va merged commit 62acab2 into master Jun 13, 2023
@rockwellwindsor-va rockwellwindsor-va deleted the API-22655-526-v2-service-description-for-validate-2 branch June 13, 2023 14:02
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
* Updates rswag_disability_compensation_request_spec for validate endpoint edscription
* compiles docs for v2 dev
Changes to be committed:
	modified:   modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
	modified:   modules/claims_api/spec/requests/v2/veterans/rswag_disability_compensation_request_spec.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants