Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api 27356 27357 docs service and logging #12974

Merged
merged 0 commits into from
Jun 13, 2023

Conversation

FonzMP
Copy link
Contributor

@FonzMP FonzMP commented Jun 12, 2023

Summary

  • Adds some generic logging and creates a bypass for failed EVSS Documents Requests. Will essentially ignore supporting docs if the service is down or responds with an error. I need to speak with VA Gov on this because it will impact how our service builds Tracked Items.
  • I also expect that we'll want to move the logging to Datadog eventually, or in the near future. We have a ticket to explore and enhance logging in v2, so we can use that ticket to investigate.

Related issue(s)

Testing done

  • Local testing and rspec

What areas of the site does it impact?

Claims Show V2 specifically and logging from within the inherited application controller.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@FonzMP FonzMP added the claimsApi modules/claims_api label Jun 12, 2023
@FonzMP FonzMP requested review from a team as code owners June 12, 2023 23:42
@va-vfs-bot va-vfs-bot temporarily deployed to API-27356-27357_docs_service_and_logging/main/main June 12, 2023 23:52 Inactive
stiehlrod
stiehlrod previously approved these changes Jun 13, 2023
@va-vsp-bot va-vsp-bot requested a deployment to API-27356-27357_docs_service_and_logging/main/main June 13, 2023 15:25 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-27356-27357_docs_service_and_logging/main/main June 13, 2023 15:50 Inactive
@FonzMP FonzMP merged commit 1ed6a25 into master Jun 13, 2023
@FonzMP FonzMP deleted the API-27356-27357_docs_service_and_logging branch June 13, 2023 18:30
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
* adds generic logging

* return empty supporting docs if errored

* update to error for display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants