Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix periodic job call to VAForms::FormReloader #12984

Merged
merged 0 commits into from
Jun 13, 2023
Merged

Fix periodic job call to VAForms::FormReloader #12984

merged 0 commits into from
Jun 13, 2023

Conversation

mathisto
Copy link
Contributor

Describe your PR in a single .gif

Whoops

Summary

The periodic sidekiq jobs should be calling VAForms::FormReloader instead of VAForms::FetchLatest. This job was broken into smaller pieces last month in #12661.

@mathisto mathisto added the banana-peels Lighthouse Banana Peels Team label Jun 13, 2023
@mathisto mathisto requested review from a team as code owners June 13, 2023 22:14
@va-vfs-bot va-vfs-bot temporarily deployed to fix-fetch-latest-job/main/main June 13, 2023 22:15 Inactive
caseywilliams
caseywilliams approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@caseywilliams caseywilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mathisto mathisto merged commit be2ac03 into master Jun 13, 2023
@mathisto mathisto deleted the fix-fetch-latest-job branch June 13, 2023 22:37
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
@mathisto
Fix periodic job call to VAForms::FormReloader (#12984)
dece55a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseywilliams caseywilliams caseywilliams approved these changes

Assignees
No one assigned
Labels
banana-peels Lighthouse Banana Peels Team console-services-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathisto @caseywilliams @va-vfs-bot