-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update flipper and resolve breaking change #17159
Conversation
<nav> | ||
<ul class="nav nav-underline mb-3 align-items-center"> | ||
<% Flipper::UI.configuration.nav_items.each do |item| %> | ||
<ul class="vads-u-margin--0 vads-u-padding--0 nav-item"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to update the ul class according to this PR.
Here's the layout file:https://github.com/flippercloud/flipper/blob/966a956f36cd0ef6a838b9ae6b20818c5509766c/lib/flipper/ui/views/layout.erb. Here's what flipper suggests:
<nav>
<ul class="nav nav-underline mb-3 align-items-center">
<% if Flipper::UI.configuration.application_href %>
<li class="nav-item">
<a class="nav-link" href="<%= Flipper::UI.configuration.application_href %>">
‹ App
</a>
</li>
<% end %>
<% Flipper::UI.configuration.nav_items.each do |item| %>
<li class="nav-item">
<a href="<%= url_for(item[:href]) %>" class="nav-link<%= " active" if request.url.start_with?(url_for(item[:href])) %>">
<%= item[:title] %>
</a>
</li>
<% end %>
<li class="nav-item ms-auto text-muted small">
<a href="https://www.flippercloud.io/docs/ui?utm_source=oss&utm_medium=ui&utm_campaign=docs">Docs</a>
•
Version: <%= Flipper::VERSION %>
</li>
</ul>
</nav>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I started with, but I changed it up just a little because I didn't love the way it looked 😆
Notable changes:
- I removed the link to Settings
- I made it an unordered list
- I changed the Docs link to link to our internal docs
- I removed the Version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yaaaas
Summary
master
, runbundle update flipper
, start your rails console and then navigate to http://127.0.0.1:3000/flipper/features. And/or run tests inspec/requests/flipper_request_spec.rb
after updating flipper.Related issue(s)
Testing done
Screenshots
Before (w/ breadcrumbs):
After (without breadcrumbs):
What areas of the site does it impact?
The Flipper UI in each env (https://staging-api.va.gov/flipper, for example)
Acceptance criteria