Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/replace Virtus models for EVSS - Part 1 #18696

Closed
wants to merge 18 commits into from

Conversation

stevenjcumming
Copy link
Contributor

@stevenjcumming stevenjcumming commented Oct 1, 2024

Summary

  • Replace Virtus model with Vets::Model
  • Boolean changes to Bool (this avoids a naming conflict)
  • The other Virtus models will be updated in another PR
  • Some models where treated like hashes so they needed to be updated
    • For example rated_disability['decision_code'] vs rated_disability.decision_code
    • 2 Mobile legacy models needed that used EVSS models to be updated as well
  • Vets::Model related updates addressed in a different PR that should be merged first

Related issue(s)

Testing done

  • manually testing to verify objects are the same with virtus and Vets::Model

Acceptance criteria

  • model(s) don't use the virtus gem (not including Common::Base)

@va-vsp-bot
Copy link
Collaborator

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: lib/evss/pciu/email_address.rb

@stevenjcumming
Copy link
Contributor Author

I switched Vets::Model from a class to a module and the last commit should reflect those changes

Copy link
Contributor

@jperk51 jperk51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mobile changes look good

@va-vfs-bot va-vfs-bot temporarily deployed to sjc-evss-vets-model-1/main/main December 4, 2024 14:51 Inactive
@stevenjcumming
Copy link
Contributor Author

Closed because EVSS is being deprecated

@va-vfs-bot va-vfs-bot temporarily deployed to sjc-evss-vets-model-1/main/main December 23, 2024 13:35 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants