Consolidate backend checks

.github/workflows/backend-pr-approver.yml

@@ -1,13 +1,30 @@
 name: Backend PR Approver
 on:
-  workflow_run:
-    workflows: 
-      - "Backend PR Labeler"
-    types: [completed]
+  pull_request:
+    types: [labeled, unlabeled]
 jobs:
-  say-hi:
+  check-approval-labels:
+    if: github.event.label.name == 'require-backend-approval' || github.event.label.name == 'ready-for-backend-review'
     runs-on: ubuntu-latest
     steps:
-      - name: Say Hi
+      - name: Check for exemption
+        id: check_exemption
         run: |
-          echo "Hi"
+          if [ ! ${{ contains(toJSON(github.event.pull_request.requested_teams.*.name), 'backend-review-group') }} ]; then
+            echo "exempt=true" >> $GITHUB_OUTPUT
+            echo "PR is exempt from backend approval."
+          else
+            echo "exempt=false" >> $GITHUB_OUTPUT
+            echo "PR requires backend approval."
+          fi
+
+      - name: Check for backend approval
+        id: check_approval
+        if: ${{ steps.check_exemption.outputs.exempt == 'false' }}
+        run: |
+          if [ ${{ contains(toJSON(github.event.pull_request.labels.*.name), 'require-backend-approval') && contains(toJSON(github.event.pull_request.labels.*.name), 'ready-for-backend-review') }} ]; then
+            echo "Pull Request missing approval."
+            exit 1
+          else
+            echo "Pull Request approved."
+          fi

.github/workflows/backend-pr-labeler.yml

@@ -74,7 +74,7 @@ jobs:
       pr_labels: ${{ needs.get-pr-data.outputs.pr_labels }}
       pr_requested_teams: ${{ needs.get-pr-data.outputs.pr_requested_teams }}
     outputs:
-      test_status: ${{ steps.get_code_checks_conclusion.outputs.test_status }}
+      test_result: ${{ steps.get_code_checks_conclusion.outputs.test_result }}
       exempt: ${{ steps.check_exemption.outputs.exempt }}
       failures_detected: ${{ steps.audit_pr_labels.outputs.failures_detected }}
     steps:
@@ -86,8 +86,8 @@ jobs:
       - name: Get Code Checks result
         if: github.event_name == 'workflow_run'
         run: |
-          echo "test_status=${{ github.event.workflow_run.conclusion }}" >> $GITHUB_OUTPUT
-          echo "test_status: ${{ github.event.workflow_run.conclusion }}"
+          echo "test_result=${{ github.event.workflow_run.conclusion }}" >> $GITHUB_OUTPUT
+          echo "test_result: ${{ github.event.workflow_run.conclusion }}"
 
       - name: Check for exemption
         id: check_exemption
@@ -107,8 +107,7 @@ jobs:
             ${{ contains(env.pr_labels, 'code-health-failure') }} || \
             ${{ contains(env.pr_labels, 'codeowners-addition-failure') }} || \
             ${{ contains(env.pr_labels, 'codeowners-delete-failure') }} || \
-            ${{ contains(env.pr_labels, 'lint-failure') }} || \
-            ${{ contains(env.pr_labels, 'test-failure') }} ; then
+            ${{ contains(env.pr_labels, 'lint-failure') }} ; then
             echo "failures_detected=true" >> $GITHUB_OUTPUT
             echo "Failure labels detected."
           else
@@ -190,7 +189,7 @@ jobs:
       pr_number: ${{ needs.get-pr-data.outputs.pr_number }}
       pr_draft: ${{ needs.get-pr-data.outputs.pr_draft }}
       pr_labels: ${{ needs.get-pr-data.outputs.pr_labels }}
-      test_status: ${{ needs.check-pr-status.outputs.test_status }}
+      test_result: ${{ needs.check-pr-status.outputs.test_result }}
       failures_detected: ${{ needs.check-pr-status.outputs.failures_detected }}
       approval_status: ${{ needs.check-approvals.outputs.approval_status }}
     steps:
@@ -201,6 +200,66 @@ jobs:
           echo ${{ env.pr_number }}
           echo ${{ env.pr_draft }}
           echo ${{ env.pr_labels }}
-          echo ${{ env.test_status }}
+          echo ${{ env.test_result }}
           echo ${{ env.failures_detected }}
           echo ${{ env.approval_status }}
+
+      # Remove labels if required
+      - name: Remove require-backend-approval label
+        if: ${{ env.exempt == 'true' && contains(env.pr_labels, 'require-backend-approval') }}
+        uses: actions-ecosystem/action-remove-labels@v1
+        with:
+          number: ${{ env.pr_number }}
+          labels: require-backend-approval
+
+      - name: Remove ready-for-backend-review label
+        if: |
+          (env.pr_draft || env.test_result == 'failure' || env.failures_detected == 'true' || env.approval_status == 'confirmed') &&
+          contains(env.pr_labels, 'ready-for-backend-review')
+        uses: actions-ecosystem/action-remove-labels@v1
+        with:
+          number: ${{ env.pr_number }}
+          labels: ready-for-backend-review
+
+      - name: Remove test-passing label
+        if: ${{ env.test_result == 'failure' && contains(fromJSON(env.pr_labels), 'test-passing') }}
+        uses: actions-ecosystem/action-remove-labels@v1
+        with:
+          number: ${{ env.pr_number }}
+          labels: test-passing
+
+      - name: Remove test-failure label
+        if: ${{ env.test_result == 'success' && contains(fromJSON(env.pr_labels), 'test-failure') }}
+        uses: actions-ecosystem/action-remove-labels@v1
+        with:
+          number: ${{ env.pr_number }}
+          labels: test-failure
+
+      # Add labels if required
+      - name: Add require-backend-approval label
+        if: ${{ env.exempt == 'false'}}
+        uses: actions-ecosystem/action-add-labels@v1
+        with:
+          number: ${{ env.pr_number }}
+          labels: require-backend-approval
+
+      - name: Add ready-for-backend-review label
+        if: ${{ env.test_result == 'success' && env.failures_detected == 'false' && env.approval_status == 'required' }}
+        uses: actions-ecosystem/action-add-labels@v1
+        with:
+          number: ${{ env.pr_number }}
+          labels: ready-for-backend-review
+
+      - name: Add test-failure label
+        if: ${{ env.test_result == 'failure' }}
+        uses: actions-ecosystem/action-add-labels@v1
+        with:
+          number: ${{ env.pr_number }}
+          labels: test-failure
+
+      - name: Add test-passing label
+        if: ${{ env.test_result == 'success' }}
+        uses: actions-ecosystem/action-add-labels@v1
+        with:
+          number: ${{ env.pr_number }}
+          labels: test-passing

.github/workflows/check_codeowners.yml

@@ -64,7 +64,7 @@ jobs:
 
     - name: Remove Failure label
       uses: actions-ecosystem/action-remove-labels@v1
-      if: ${{ success() }}
+      if: ${{ success() && contains(github.event.pull_request.labels.*.name, 'codeowners-addition-failure') }}
       with:
         number: ${{ github.event.pull_request.number }}
         labels: |

.github/workflows/code_checks.yml

@@ -1,4 +1,4 @@
-name: Code Checks
+name: "Code Checks"
 on:
   push:
     branches: [master]
@@ -21,14 +21,6 @@ jobs:
         with:
           bundler-cache: true
 
-      - name: Remove Review label
-        if:  github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'ready-for-backend-review')
-        uses: actions-ecosystem/action-remove-labels@v1
-        with:
-          number: ${{ github.event.pull_request.number }}
-          labels: |
-            ready-for-backend-review
-
       - name: Run bundle-audit (checks gems for CVE issues)
         run: bundle exec bundle-audit check --update --ignore CVE-2024-27456
 
@@ -64,6 +56,8 @@ jobs:
       COMPOSE_DOCKER_CLI_BUILD: 1
     permissions: write-all
     runs-on: ubuntu-32-cores-latest
+    outputs:
+      test_status: ${{ steps.test-status.outputs.status }}
     steps:
       - uses: actions/checkout@v4
 
@@ -92,22 +86,6 @@ jobs:
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3
 
-      - name: Remove Review label
-        if:  github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'ready-for-backend-review')
-        uses: actions-ecosystem/action-remove-labels@v1
-        with:
-          number: ${{ github.event.pull_request.number }}
-          labels: |
-            ready-for-backend-review
-
-      - name: Remove Test Passing label
-        if: github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'test-passing')
-        uses: actions-ecosystem/action-remove-labels@v1
-        with:
-          number: ${{ github.event.pull_request.number }}
-          labels: |
-            test-passing
-
       - name: Build Docker Image
         uses: docker/build-push-action@v6
         env:
@@ -155,70 +133,6 @@ jobs:
           path: log/*.xml
           if-no-files-found: ignore
 
-      - name: Add Test Failure label
-        if: failure() && github.event_name == 'pull_request'
-        uses: actions-ecosystem/action-add-labels@v1
-        with:
-          number: ${{ github.event.pull_request.number }}
-          labels: |
-            test-failure
-
-      - name: Remove Test Failure label
-        if: success() && github.event_name == 'pull_request'
-        uses: actions-ecosystem/action-remove-labels@v1
-        with:
-          number: ${{ github.event.pull_request.number }}
-          labels: |
-            test-failure
-
-      - name: Add Test Passing label
-        if: success() && github.event_name == 'pull_request'
-        uses: actions-ecosystem/action-add-labels@v1
-        with:
-          number: ${{ github.event.pull_request.number }}
-          labels: |
-            test-passing
-
-      - name: Add omit-backend-approval label
-        if: |
-          github.event_name == 'pull_request' && github.event.pull_request.draft == false &&
-          (
-            contains(toJSON(github.event.pull_request.requested_teams.*.name), 'mobile') ||
-            contains(toJSON(github.event.pull_request.requested_teams.*.name), 'lighthouse') ||
-            contains(toJSON(github.event.pull_request.requested_teams.*.name), 'identity')
-          )
-        uses: actions-ecosystem/action-add-labels@v1
-        with:
-          number: ${{ github.event.pull_request.number }}
-          labels: |
-            omit-backend-approval
-
-      - name: Add require-backend-approval label
-        uses: actions-ecosystem/action-add-labels@v1
-        if: |
-            github.event_name == 'pull_request' && github.event.pull_request.draft == false &&
-            !contains(toJSON(github.event.pull_request.requested_teams.*.name), 'mobile') &&
-            !contains(toJSON(github.event.pull_request.requested_teams.*.name), 'lighthouse') &&
-            !contains(toJSON(github.event.pull_request.requested_teams.*.name), 'identity')
-        with:
-          number: ${{ github.event.pull_request.number }}
-          labels: |
-            require-backend-approval
-
-      - name: Add Review label
-        uses: actions-ecosystem/action-add-labels@v1
-        if: |
-          github.event_name == 'pull_request' && success() && github.event.pull_request.draft == false &&
-          !contains(github.event.pull_request.labels.*.name, 'code-health-failure') &&
-          !contains(github.event.pull_request.labels.*.name, 'codeowners-addition-failure') &&
-          !contains(github.event.pull_request.labels.*.name, 'codeowners-delete-failure') &&
-          !contains(github.event.pull_request.labels.*.name, 'lint-failure') &&
-          !contains(github.event.pull_request.labels.*.name, 'test-failure')
-        with:
-          number: ${{ github.event.pull_request.number }}
-          labels: |
-            ready-for-backend-review
-
   publish_results:
     name: Publish Test Results and Coverage
     if: always()