Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cont. updating mobile specs to use committee gem #19148

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Conversation

aherzberg
Copy link
Contributor

@aherzberg aherzberg commented Oct 29, 2024

Summary

cont. updating mobile specs to use committee gem

Related issue(s)

department-of-veterans-affairs/va-mobile-app#9776

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Tonksthebear
Tonksthebear previously approved these changes Oct 30, 2024
Copy link
Contributor

@Tonksthebear Tonksthebear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rmtolmach
Copy link
Contributor

@aherzberg once you get a re-review from @Tonksthebear, I'll review.

Copy link
Contributor

@Tonksthebear Tonksthebear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Nov 4, 2024

Backend-review-group approval confirmed.

@aherzberg aherzberg merged commit 7269442 into master Nov 4, 2024
25 of 26 checks passed
@aherzberg aherzberg deleted the 9776-add-specs branch November 4, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants