Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-39223] Update poa docs to include dependent claimants #19179

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

tycol7
Copy link
Contributor

@tycol7 tycol7 commented Oct 30, 2024

⚠️ Do not merge until after release

Summary

  • Add new Appointing an accredited representative for dependents section under Background for v1 and v2.
  • Update endpoint descriptions:
    • v1 POST /forms/2122
    • v2 POST /veterans/{veteranId}/2122
    • v2 POST /veterans/{veteranId}/2122a

Related issue(s)

API-39223

Testing done

  • New code is covered by unit tests
  • Visual inspection

Screenshots

New section (v1)
new-section-v1

New section (v2)
new-section-v2

POST /2122 (v1)
v1-2122

POST /2122 (v2)
v2-2122

POST /2122a (v2)
v2-2122a

What areas of the site does it impact?

v1 and v2 docs

Acceptance criteria

  • I updated unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

N/A

@tycol7 tycol7 added the claimsApi modules/claims_api label Oct 30, 2024
@tycol7 tycol7 requested a review from a team as a code owner October 30, 2024 19:07
@tycol7 tycol7 force-pushed the tdc/oas-dependent-claimant-docs branch from a05f91d to 1f5daad Compare October 30, 2024 19:13
@va-vfs-bot va-vfs-bot temporarily deployed to tdc/oas-dependent-claimant-docs/main/main October 30, 2024 19:32 Inactive
@tycol7 tycol7 changed the title [API-40651] Update poa docs to include dependent claimants [API-39223] Update poa docs to include dependent claimants Oct 30, 2024
@tycol7 tycol7 merged commit f240922 into master Nov 5, 2024
23 checks passed
@tycol7 tycol7 deleted the tdc/oas-dependent-claimant-docs branch November 5, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants