Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add correct Datadog service tag to FlagAccreditedRepresentativesController #19208

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Add correct Datadog service tag to FlagAccreditedRepresentativesController #19208

merged 1 commit into from
Nov 1, 2024

Conversation

holdenhinkle
Copy link
Contributor

@holdenhinkle holdenhinkle commented Oct 31, 2024 •
edited
Loading

Resolves department-of-veterans-affairs/va.gov-team#93851

Summary

  • This PR adds the correct Datadog service tag to FlagAccreditedRepresentativesController

Related issue(s)

Testing done

NA

Screenshots

NA

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

NA

@holdenhinkle holdenhinkle requested review from a team as code owners October 31, 2024 22:14
@holdenhinkle holdenhinkle mentioned this pull request Oct 31, 2024
Closed
4 tasks
opticbob
opticbob approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@opticbob opticbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

Backend-review-group approval confirmed.

@holdenhinkle holdenhinkle merged commit 33036a7 into master Nov 1, 2024
29 of 30 checks passed
@holdenhinkle holdenhinkle deleted the hh-93851-add-arm-service-tag-to-all-controllers branch November 1, 2024 20:07
pennja pushed a commit that referenced this pull request Nov 8, 2024
@holdenhinkle @Japenner
add correct service tag to FlagAccreditedRepresentativesController (#…
564fbb0 
…19208)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opticbob opticbob opticbob approved these changes

@rmtolmach rmtolmach rmtolmach approved these changes

Assignees
No one assigned
Labels
require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure existing Datadog monitoring meets Platform's new tagging standards
4 participants
@holdenhinkle @rmtolmach @opticbob @va-vfs-bot