API-39840-check-empty-birls-id

[stiehlrod]

Summary

• Adds file number check, if empty, to supporting docs.
• Adds tests.

Related issue(s)

• API-39840

Testing done

• New code is covered by unit tests
• Postman steps:

1. hit v2 claims show.
2. this claim has supporting docs: {{uri}}/services/claims/v2/veterans/1012853277V552077/claims/600579354
3. put a debugger here and set file_number to ""
4. the response should be a really quick 200 without supporting docs because it skipped the upload and retrieval process for docs

What areas of the site does it impact?

modified:   modules/claims_api/app/controllers/concerns/claims_api/v2/claims_requests/supporting_documents.rb
modified:   modules/claims_api/spec/concerns/claims_api/v2/claims_requests/supporting_documents_spec.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[rockwellwindsor-va]

@stiehlrod Looks like there are failing tests related to the work ( I think)

[mchristiansonVA]

Looks better to me!