Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Btsss/mask claim id logs #19300

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Btsss/mask claim id logs #19300

merged 3 commits into from
Nov 7, 2024

Conversation

kjduensing
Copy link
Contributor

@kjduensing kjduensing commented Nov 6, 2024

Summary

For requests to the claims/{claim_id} endpoint, scrub the claim ID which may be considered PII to prevent leakage when logging.

Related issue(s)

Closes department-of-veterans-affairs/va.gov-team#93791

Testing done

Semantic logging not used during testing. Will test in staging

What areas of the site does it impact?

Travel Pay Logging

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

liztownd
liztownd previously approved these changes Nov 6, 2024
Copy link
Contributor

@liztownd liztownd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good! I know we still need to test in Staging, but I'm ok to merge it so we can test it out.

@kjduensing kjduensing marked this pull request as ready for review November 7, 2024 15:32
@kjduensing kjduensing requested review from a team as code owners November 7, 2024 15:32
@RachalCassity RachalCassity self-assigned this Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

Backend-review-group approval confirmed.

@kjduensing kjduensing merged commit f03d23b into master Nov 7, 2024
37 checks passed
@kjduensing kjduensing deleted the btsss/mask-claim-id-logs branch November 7, 2024 20:06
pennja pushed a commit that referenced this pull request Nov 8, 2024
* Mask claim ID in logs

* Rubocop fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure claim information is masked in logs and URIs
4 participants