-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Btsss/mask claim id logs #19300
Merged
Merged
Btsss/mask claim id logs #19300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts-api into btsss/mask-claim-id-logs
va-vfs-bot
temporarily deployed
to
btsss/mask-claim-id-logs/main/main
November 6, 2024 20:36
Inactive
liztownd
previously approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good! I know we still need to test in Staging, but I'm ok to merge it so we can test it out.
liztownd
approved these changes
Nov 7, 2024
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
Nov 7, 2024
RachalCassity
approved these changes
Nov 7, 2024
Backend-review-group approval confirmed. |
pennja
pushed a commit
that referenced
this pull request
Nov 8, 2024
* Mask claim ID in logs * Rubocop fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For requests to the
claims/{claim_id}
endpoint, scrub the claim ID which may be considered PII to prevent leakage when logging.Related issue(s)
Closes department-of-veterans-affairs/va.gov-team#93791
Testing done
Semantic logging not used during testing. Will test in staging
What areas of the site does it impact?
Travel Pay Logging
Acceptance criteria