-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API-35332] View POA Requests - Filtering #19306
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
tdc/view-poa-requests-filtering/main/main
November 6, 2024 21:49
Inactive
va-vfs-bot
temporarily deployed
to
tdc/view-poa-requests-filtering/main/main
November 7, 2024 00:08
Inactive
tycol7
force-pushed
the
tdc/view-poa-requests-filtering
branch
from
November 7, 2024 21:57
b4658c7
to
2f7b111
Compare
tycol7
force-pushed
the
tdc/view-poa-requests-filtering
branch
from
November 7, 2024 22:12
2f7b111
to
65165d5
Compare
va-vfs-bot
temporarily deployed
to
tdc/view-poa-requests-filtering/main/main
November 7, 2024 23:10
Inactive
va-vfs-bot
temporarily deployed
to
tdc/view-poa-requests-filtering/main/main
November 8, 2024 00:16
Inactive
tycol7
commented
Nov 8, 2024
Comment on lines
+59
to
+69
context 'when pageIndex is present but pageSize is not' do | ||
before do | ||
allow(subject).to receive(:form_attributes).and_return({ 'poaCodes' => %w[002 003 083], 'pageIndex' => '2' }) | ||
end | ||
|
||
it 'raises a ParameterMissing error' do | ||
expect do | ||
subject.index | ||
end.to raise_error(Common::Exceptions::ParameterMissing) | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed this test in #19268, so adding here.
github-actions
bot
added
require-backend-approval
lint-failure
and removed
omit-backend-approval
test-passing
labels
Nov 12, 2024
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
Nov 12, 2024
github-actions
bot
added
audit-service-failure
test-failure
test-passing
and removed
lint-failure
test-failure
labels
Nov 12, 2024
github-actions
bot
added
require-backend-approval
omit-backend-approval
and removed
require-backend-approval
labels
Nov 12, 2024
FonzMP
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
filter
key to the POA request with the following keys:status
, an array of enums (NEW
,ACCEPTED
,DECLINED
)state
city
country
Related issue(s)
API-35332
Testing done
Testing steps
Connect to BGS.
Send the following request:
Observe the following response:
Adjust filters and resend as desired.
Screenshots
What areas of the site does it impact?
Acceptance criteria
Requested Feedback
N/A