-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api 28113 replace bgs ext poa updater #19325
Conversation
…cord failed with code BPNQ0100'
…failing tests. Created a ticket to remove that method from local_bgs since it exists in two places.
…replaces vcr cassette.
…s. Need to re-record vcr cassette.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested call to v1 PUT /forms/2122 locally and confirmed the findPersonBySSN call is correctly calling the PersonWebService find_by_ssn method, and that the call completed successfully.
Manually confirmed the VetRecordService endpoint namespace resolves to the correct value via Ruby console call:
irb(main):017> ClaimsApi::LocalBGS.new(external_uid:'a', external_key:'b').fetch_namespace(Faraday::Connection.new(ssl: { verify_mode: @ssl_verify_mode }), 'VetRecordServiceBean/VetRecordWebService')
2024-11-27 09:26:28.062902 I [50061:11460 claim_logger.rb:17] Rails -- ClaimsApi :: local_bgs :: event: connection_wsdl_get :: endpoint: VetRecordServiceBean/VetRecordWebService :: duration: 1.1226 :: Location: /Users/matthewchristianson/development/vets-api/modules/claims_api/lib/bgs_service/local_bgs.rb:358
=> "http://services.share.benefits.vba.va.gov/"
Looks good to me!
Summary
Related issue(s)
Testing done
Screenshots
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria