Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api 28113 replace bgs ext poa updater #19325

Merged
merged 26 commits into from
Dec 2, 2024

Conversation

stiehlrod
Copy link
Contributor

@stiehlrod stiehlrod commented Nov 7, 2024

Summary

  • Adds flipper feature.
  • Moves the find_by_ssn call to PersonWebService from LocalBgs.
  • Adds VetRecordService to LocalBgs.
  • Adds ability to switch between bgs-ext & local_bgs for vet_record & person_web_service.

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Postman {{uri}}/services/claims/v1/forms/2122/38d26cfb-74ca-46dc-bd77-308799130bd7
  • Rails c
@ssl_verify_mode =
if Settings.bgs.ssl_verify_mode == 'none'
OpenSSL::SSL::VERIFY_NONE
else
OpenSSL::SSL::VERIFY_PEER
end

ClaimsApi::LocalBGS.new(external_uid:'a', external_key:'b').fetch_namespace(Faraday::Connection.new(ssl: { verify_mode: @ssl_verify_mode }), 'VetRecordServiceBean/VetRecordWebService')

Screenshots

Screenshot 2024-11-14 at 2 33 26 PM

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@stiehlrod stiehlrod self-assigned this Nov 7, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to API-28113-replace-bgs-ext-poa-updater/main/main November 7, 2024 18:02 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-28113-replace-bgs-ext-poa-updater/main/main November 7, 2024 19:16 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-28113-replace-bgs-ext-poa-updater/main/main November 7, 2024 20:52 Inactive
…failing tests. Created a ticket to remove that method from local_bgs since it exists in two places.
@va-vfs-bot va-vfs-bot temporarily deployed to API-28113-replace-bgs-ext-poa-updater/main/main November 12, 2024 21:26 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-28113-replace-bgs-ext-poa-updater/main/main November 14, 2024 14:28 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-28113-replace-bgs-ext-poa-updater/main/main November 15, 2024 21:07 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-28113-replace-bgs-ext-poa-updater/main/main November 15, 2024 22:05 Inactive
@stiehlrod stiehlrod requested a review from a team November 22, 2024 20:16
Copy link
Contributor

@mchristiansonVA mchristiansonVA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested call to v1 PUT /forms/2122 locally and confirmed the findPersonBySSN call is correctly calling the PersonWebService find_by_ssn method, and that the call completed successfully.

Manually confirmed the VetRecordService endpoint namespace resolves to the correct value via Ruby console call:

irb(main):017> ClaimsApi::LocalBGS.new(external_uid:'a', external_key:'b').fetch_namespace(Faraday::Connection.new(ssl: { verify_mode: @ssl_verify_mode }), 'VetRecordServiceBean/VetRecordWebService')
2024-11-27 09:26:28.062902 I [50061:11460 claim_logger.rb:17] Rails -- ClaimsApi :: local_bgs :: event: connection_wsdl_get :: endpoint: VetRecordServiceBean/VetRecordWebService :: duration: 1.1226 :: Location: /Users/matthewchristianson/development/vets-api/modules/claims_api/lib/bgs_service/local_bgs.rb:358
=> "http://services.share.benefits.vba.va.gov/"

Looks good to me!

@stiehlrod stiehlrod merged commit fc06924 into master Dec 2, 2024
32 checks passed
@stiehlrod stiehlrod deleted the API-28113-replace-bgs-ext-poa-updater branch December 2, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants