Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VEBT-777 - Add API's to connect to four DGIB endpoints for VYE #19331
VEBT-777 - Add API's to connect to four DGIB endpoints for VYE #19331
Changes from 24 commits
4fa3eee
cacb020
5bd8774
7a5ef34
91d6857
865784f
e65ddd4
b1c9799
bde066e
d03b6f1
cba3483
578996e
13d6292
ca503ec
43fda79
28216f6
f3381e6
fd6bfc7
97c7432
cf0d483
2272782
6fae674
3e08bf8
aa92b80
82519ed
95b0b44
37dcc34
6566fb0
5107668
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these policies be combined since they are the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on our understanding of how Pundit works, we need to have a policy ending with ? that matches each corresponding action in the controller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the controller you can call one policy:
modules/vye/app/controllers/vye/v1/dgib_verifications_controller.rb
before_action { authorize :vye, :access? }
app/policies/vye_policy.rb ### NEW POLICY FILE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this service not added to the original breakers initializer? Matching redis namespaces can cause all the data in the other redis namespace to disappear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on our understanding, we added this to the original vets-api breakers initializer. Good catch, thanks for bringing this to our attention, we're still learning our way around this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand. Thank you for making all these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file needs to be removed. Breakers client should not be re-initialized.