-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIMPLE-FORMS] doc: update form_submission_pdf_backups.md #19436
Merged
pennja
merged 2 commits into
master
from
jap/simple-forms/1840-minor-documentation-tweaks-01
Nov 18, 2024
Merged
[SIMPLE-FORMS] doc: update form_submission_pdf_backups.md #19436
pennja
merged 2 commits into
master
from
jap/simple-forms/1840-minor-documentation-tweaks-01
Nov 18, 2024
+14
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
Nov 13, 2024
va-vfs-bot
temporarily deployed
to
jap/simple-forms/1840-minor-documentation-tweaks-01/main/main
November 13, 2024 13:55
Inactive
ndsprinkle
previously approved these changes
Nov 13, 2024
github-actions
bot
added
test-failure
test-passing
ready-for-backend-review
and removed
test-failure
labels
Nov 13, 2024
pennja
force-pushed
the
jap/simple-forms/1840-minor-documentation-tweaks-01
branch
from
November 15, 2024 14:35
898a134
to
8897a5f
Compare
github-actions
bot
added
require-backend-approval
ready-for-backend-review
and removed
require-backend-approval
ready-for-backend-review
labels
Nov 15, 2024
va-vfs-bot
temporarily deployed
to
jap/simple-forms/1840-minor-documentation-tweaks-01/main/main
November 15, 2024 14:36
Inactive
github-actions
bot
added
require-backend-approval
test-passing
ready-for-backend-review
and removed
require-backend-approval
labels
Nov 15, 2024
va-vfs-bot
temporarily deployed
to
jap/simple-forms/1840-minor-documentation-tweaks-01/main/main
November 15, 2024 14:49
Inactive
Thrillberg
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
pennja
force-pushed
the
jap/simple-forms/1840-minor-documentation-tweaks-01
branch
from
November 18, 2024 13:56
bd769e7
to
efd5299
Compare
github-actions
bot
added
require-backend-approval
and removed
ready-for-backend-review
require-backend-approval
test-passing
labels
Nov 18, 2024
rmtolmach
approved these changes
Nov 18, 2024
Backend-review-group approval confirmed. |
pennja
deleted the
jap/simple-forms/1840-minor-documentation-tweaks-01
branch
November 18, 2024 22:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Testing done
What areas of the site does it impact?
Acceptance criteria
Requested Feedback
I would appreciate feedback on the clarity and organization of the new documentation structure. Are the PDF download instructions easy to follow? Is there anything else that could be improved to enhance user understanding? Thank you!