API-42025-update-v2-poa-schema-to-allow-empty-string-email

[rockwellwindsor-va]

Summary

• Updates REGEX pattern in V2 2122.json and 2122a.json so that an empty string can also pass the validation
• Adds tests for validating the REGEX expectations

Related issue(s)

API-42025

Testing done

• New code is covered by unit tests

Screenshots

Note: Optional

What areas of the site does it impact?

modified:   modules/claims_api/config/schemas/v2/2122.json
modified:   modules/claims_api/config/schemas/v2/2122a.json
modified:   modules/claims_api/spec/requests/v2/veterans/power_of_attorney/2122_spec.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

Please try to break this REGEX with anything you can think to send in. I am always hesitant to do REGEX changes. This appeared to validate expected email formats like va.gov@email.com, email@email.com etc. While I do feel it is dialed in always skeptical and leery of my REGEX changes.

[mchristiansonVA]

Tested v2 2122 & 2122a with empty veteran/claimant/serviceOrganization emails and confirmed they're allowed by schema. Looks good to me!

[rmtolmach]

sorry, looks like you were blocked from merging.

[github-actions]

Backend-review-group approval confirmed.