Travel Pay/improve error handling

[liztownd]

Summary

• This work is behind a feature toggle (flipper): YES

• (Summarize the changes that have been made to the platform)
  Since we're integrating the appt > claim association work into other BE API work, we can't just be throwing random exceptions. This work wraps the specific service call in another layer to provide details error messaging to forward to the other service that will integrate with it.

• (Which team do you work for, does your team own the maintenance of this component?)
  Travel pay

Related issue(s)

• Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira
• #91972
• Link to epic if not included in ticket
• #91550 (mobile) & #83829 (web)

Testing done

• New code is covered by unit tests
• Describe what the old behavior was prior to the change
  I would just throw an error, not forward the error message to the next service
• Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  Not in use anywhere, must log into ArgoCD and test once it's in Staging.

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)
Travel Pay module

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

1 Warning

⚠️

This PR changes 332 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/travel_pay/app/services/travel_pay/claim_association_service.rb (+78/-36) modules/travel_pay/spec/services/claims_association_service_spec.rb (+160/-58) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger