Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to Simple Forms API README about native setup #19462

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

derekhouck
Copy link
Contributor

@derekhouck derekhouck commented Nov 14, 2024

Summary

  • Adds some clarification to the README for the simple_forms_api module about the setup needed to run the rails command locally as well was the path needed by the command to find the appropriate PDF file.

Testing done

  • Ran the rails command referenced in the README successfully using the new instructions.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

It would be nice to be able to run this command using the Docker setup, but that would be a more involved fix.

@va-vfs-bot va-vfs-bot temporarily deployed to dh-update-simple-forms-readme/main/main November 14, 2024 18:31 Inactive
@derekhouck derekhouck requested a review from ryguyk November 14, 2024 19:28
@derekhouck derekhouck marked this pull request as ready for review November 14, 2024 19:28
@derekhouck derekhouck requested review from a team as code owners November 14, 2024 19:28
@derekhouck derekhouck changed the title Add note about native setup Add note to Simple Forms API README about native setup Nov 14, 2024
Copy link

Backend-review-group approval confirmed.

@RachalCassity RachalCassity self-assigned this Nov 15, 2024
@derekhouck derekhouck merged commit f2cea57 into master Nov 15, 2024
66 of 67 checks passed
@derekhouck derekhouck deleted the dh-update-simple-forms-readme branch November 15, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants