Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump prawn 2.4.0 -> 2.5.0 #19474

Merged
merged 12 commits into from
Nov 25, 2024
Merged

Bump prawn 2.4.0 -> 2.5.0 #19474

merged 12 commits into from
Nov 25, 2024

Conversation

ryan-mcneil
Copy link
Contributor

@ryan-mcneil ryan-mcneil commented Nov 15, 2024 •
edited by ericboehs
Loading

Summary

department-of-veterans-affairs/va.gov-team#97579

  • Bump prawn 2.4.0 -> 2.5.0

NOTES:

  • On the initial run of the specs, the following warning appeared thousands of times, but after that run, it was never seen again. Just making note in case it's seen in the future:
    Warning: parser advancing for unknown reason. Potential data-loss.
  • Ultimately I replaced the 16 PDF test cases used in the failing tests with new ones. If you look at the second to last commit, you can compare the new and old PDFs, which visually appear the same

Related issue(s)

@ryan-mcneil ryan-mcneil requested a review from a team as a code owner November 15, 2024 00:13
@va-vfs-bot va-vfs-bot temporarily deployed to rm-bump-prawn-2.5/main/main November 15, 2024 00:19 Inactive
@ryan-mcneil ryan-mcneil requested a review from a team as a code owner November 20, 2024 21:38
@va-vfs-bot va-vfs-bot temporarily deployed to rm-bump-prawn-2.5/main/main November 20, 2024 22:08 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to rm-bump-prawn-2.5/main/main November 20, 2024 23:46 Inactive
@ryan-mcneil ryan-mcneil requested review from a team as code owners November 22, 2024 00:37
@github-actions GitHub Actions
Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/fixtures/pdf_fill/21-0781a/overflow_extras.pdf

@github-actions GitHub Actions
Copy link

Backend-review-group approval confirmed.

wayne-weibel
wayne-weibel approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@wayne-weibel wayne-weibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With all the tests passing I do not see a reason to complicate this PR.

When I was looking at replacing Prawn/PDFtk with HexaPDF I ran into a similar issue. Visually the PDF will be the same, but the underlying markup is constructed differently, so any comparison shows as being different.
I would usually have a generated version from master (renamed) then generate one on my branch and do a “compare” in the console.
A potential alternative to this would be to use Identikal, but that would require changing all of the unit tests.

@ryan-mcneil ryan-mcneil merged commit 13e4739 into master Nov 25, 2024
31 checks passed
@ryan-mcneil ryan-mcneil deleted the rm-bump-prawn-2.5 branch November 25, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjohnson2011 rjohnson2011 rjohnson2011 approved these changes

@wayne-weibel wayne-weibel wayne-weibel approved these changes

Assignees
No one assigned
Labels
require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryan-mcneil @wayne-weibel @rjohnson2011 @va-vfs-bot