New feature flag for adding the Flash 'Amyotrophic Lateral Sclerosis' to 526 disability compensation prior to submission

[dfitchett]

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

• This work is behind a feature toggle (flipper): YES
• Our team has been tasked with implementing the addition of several flashes to be applied to 526 disability compensation forms filed through VA.gov. More information on the work can be found in this presentation WIP.
• This work adds the feature toggle and supporting implementation to add the flash Amyotrophic Lateral Sclerosis to a disability compensation form.
• I'm on the Employee Experience team; we work with the Disability Experience team which maintains Form 526.
• Flipper will be retired upon the successful 100% rollout of feature to users. This process could take several months as claims with conditions fitting the criteria of applying the flash are scarce (about 1600 in FY2024).

Related issue(s)

• Milestone
• ticket
• mural

Testing done

• New code is covered by unit tests
• Old behavior: ALS flash was not applied for new or increase conditions matching ALS
• New behavior:
  • for claims for increase on a ALS condition with diagnostic code 8017 the flash will be applied
  • for claims for new conditions case-insensitve matching will be performed:
    • exact matching only: ALS
    • partial matching will apply on these terms: amyotrophic lateral sclerosis and (als)
    • exact matching and fuzzy matching applied with these terms:
      • lou gehrig disease
      • lou gehrigs disease
      • lou gehrig's disease
      • lou gehrig
      • lou gehrigs
      • lou gehrig's
  • More information on these can be found in this google sheet.
• When deployed to staging, testing will be done by submitting claims with new and CFI conditions matching the requirements above, and the flash will be verified in VBMS UAT on the established claim.
• If this work is behind a flipper:
  • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • tests for feature flag in spec/lib/bgs/disability_compensation_form_flashes_spec.rb
  • What is the testing plan for rolling out the feature?
    • Testing will be completed in staging first to verify behavior
    • Feature will be released to small percentage of veteran users until verification can happen in prod

What areas of the site does it impact?

• no user functionality is affected

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
  • Monitor
  • Dashboard

[github-actions]

1 Warning

⚠️

This PR changes 226 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files app/models/concerns/form526_claim_fast_tracking_concern.rb (+14/-3) app/models/saved_claim/disability_compensation.rb (+2/-1) app/services/claim_fast_tracking/flash_picker.rb (+58/-0) config/features.yml (+4/-0) lib/bgs/disability_compensation_form_flashes.rb (+12/-1) spec/lib/bgs/disability_compensation_form_flashes_spec.rb (+43/-1) spec/services/claim_fast_tracking/flash_picker_spec.rb (+87/-0) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[nanotone]

LGTM!