Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pension_military_prefill flipper #19490

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

TaiWilkin
Copy link
Contributor

@TaiWilkin TaiWilkin commented Nov 18, 2024

Summary

  • Removes the flipper pension_military_history

Related issue(s)

https://github.com/orgs/department-of-veterans-affairs/projects/1278/views/4?pane=issue&itemId=71138421&issue=department-of-veterans-affairs%7Cva.gov-team%7C88486

Testing done

  • New code is covered by unit tests
  • Login as vets.gov.user+233@gmail.com on the review deployment (set oauth=false and use ID.me) and start a new Pensions form. The Applicant Information page should be filled out as usual. The email address and phone number fields should be filled in. The service branch should be Army, and the start and end dates should be filled in. The service number should be the veteran's SSN (prefilled on Applicant Information).

What areas of the site does it impact?

Pensions

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Copy link
Contributor

@mjknight50 mjknight50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is deployed, you'll need to follow step 3 of this section of this guide to completely remove this toggle. You'll need to do it in the terminal of each ArgoCD environment. If you or no one on your team has access to those terminals, let me know and I can do it for you. Remember, don't delete them in Argo until the code has been deployed.

Copy link

Backend-review-group approval confirmed.

@TaiWilkin TaiWilkin merged commit 3416435 into master Nov 18, 2024
67 checks passed
@TaiWilkin TaiWilkin deleted the pensions/remove-military-prefill-flipper branch November 18, 2024 16:10
@TaiWilkin
Copy link
Contributor Author

The flipper has been removed from each environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants