Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vebt 796 - Add ClearDeactivatedBDNs to scheduled jobs #19492

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Conversation

alexchan-va
Copy link
Contributor

@alexchan-va alexchan-va commented Nov 18, 2024

Summary

  • This work is behind a feature toggle (flipper): YES/NO No
  • (Summarize the changes that have been made to the platform) Auto delete BDNs and awards from Sundown Sweep.
  • (If bug, how to reproduce) N/A
  • (What is the solution, why is this the solution?) Add the ClearDeactivatedBDNs script to the periodic jobs.
  • (Which team do you work for, does your team own the maintenance of this component?) VEBT

Related issue(s)

Testing done

  • [x ] New code is covered by unit tests
  • Describe what the old behavior was prior to the change N/A - this script was being executed manually before
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas) Sundown Sweep

Acceptance criteria

  • [x ] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • [x ] No error nor warning in the console.
  • [x ] Events are being sent to the appropriate logging solution
  • [x ] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@alexchan-va alexchan-va changed the title Vebt 796 Vebt 796 - Add ClearDeactivatedBDNs to scheduled jobs Nov 18, 2024
@RachalCassity RachalCassity self-assigned this Nov 19, 2024
Copy link

Backend-review-group approval confirmed.

@alexchan-va alexchan-va merged commit 511f7f7 into master Nov 19, 2024
26 checks passed
@alexchan-va alexchan-va deleted the vebt-796 branch November 19, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants