Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10-10CG] Update Form1010cg::SubmissionJob spec to stub all Flipper calls #19495

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

coope93
Copy link
Contributor

@coope93 coope93 commented Nov 18, 2024

Summary

  • This work is behind a feature toggle (flipper): YES
  • Added allow(Flipper).to receive(:enabled?).and_call_original in a before for the Form1010cg::SubmissionJob to ensure any Flipper toggles are stubbed. SavedClaim::CaregiversAssistanceClaim was expecting a different flipper toggle to be stubbed and it wasn't, so it was using the stub from the spec that was for a different feature.
  • 10-10 Health Apps

Related issue(s)

Testing done

  • New code is covered by unit tests

Screenshots

None

What areas of the site does it impact?

10-10CG Submission Job Spec

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

…ion spec since the underlying SavedClaim is expecting the Flipper toggle to be stubbed
@coope93 coope93 marked this pull request as ready for review November 18, 2024 19:30
@coope93 coope93 requested review from a team as code owners November 18, 2024 19:30
@va-vfs-bot va-vfs-bot temporarily deployed to fix-10-10cg-submission-spec-flipper/main/main November 18, 2024 19:42 Inactive
Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

Backend-review-group approval confirmed.

@rmtolmach rmtolmach merged commit 340bec8 into master Nov 18, 2024
54 checks passed
@rmtolmach rmtolmach deleted the fix-10-10cg-submission-spec-flipper branch November 18, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants