Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-42061] Add periods and apostrophes to docs #19496

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

tycol7
Copy link
Contributor

@tycol7 tycol7 commented Nov 18, 2024

Summary

  • Add periods and apostrophes to v1 and v2 docs (all environments).

Related issue(s)

API-42061

Testing done

  • Visual inspection.

Screenshots

v1
v1-period

v1-2122

v2

2122a 2122

What areas of the site does it impact?

Swagger docs (all environments)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

N/A

@tycol7 tycol7 added the claimsApi modules/claims_api label Nov 18, 2024
@tycol7 tycol7 requested a review from a team as a code owner November 18, 2024 19:31
@va-vfs-bot va-vfs-bot temporarily deployed to tdc/update-dependent-docs/main/main November 18, 2024 19:42 Inactive
Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tycol7 tycol7 merged commit 101d660 into master Nov 20, 2024
24 checks passed
@tycol7 tycol7 deleted the tdc/update-dependent-docs branch November 20, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants