-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove BGS-ext services from healthchecks #19587
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
omit-backend-approval
test-failure
and removed
omit-backend-approval
labels
Nov 22, 2024
va-vfs-bot
temporarily deployed
to
API-41368-remove-bgs-ext-okcomputer/main/main
November 25, 2024 19:30
Inactive
stiehlrod
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions
bot
added
require-backend-approval
and removed
omit-backend-approval
labels
Nov 27, 2024
va-vfs-bot
temporarily deployed
to
API-41368-remove-bgs-ext-okcomputer/main/main
November 27, 2024 18:26
Inactive
github-actions
bot
added
require-backend-approval
ready-for-backend-review
and removed
require-backend-approval
test-passing
labels
Dec 2, 2024
va-vfs-bot
temporarily deployed
to
API-41368-remove-bgs-ext-okcomputer/main/main
December 2, 2024 15:28
Inactive
github-actions
bot
added
omit-backend-approval
and removed
require-backend-approval
labels
Dec 2, 2024
github-actions
bot
added
omit-backend-approval
test-failure
and removed
test-passing
labels
Dec 2, 2024
va-vfs-bot
temporarily deployed
to
API-41368-remove-bgs-ext-okcomputer/main/main
December 2, 2024 16:40
Inactive
github-actions
bot
added
omit-backend-approval
test-passing
ready-for-backend-review
and removed
omit-backend-approval
test-failure
labels
Dec 2, 2024
github-actions
bot
added
omit-backend-approval
and removed
omit-backend-approval
test-passing
labels
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
API-41368
Testing done
Output example
{"default":{"message":"Application is running","success":true,"time":3.00002284348011e-06},"database":{"message":"Schema version: 20241108144805","success":true,"time":0.08352900005411357},"mpi":{"message":"MPI is running","success":true,"time":1.0000017937272787e-05},"localbgs-claimant":{"message":"Faraday BGS ClaimantServiceBean/ClaimantWebService is unavailable","success":false,"time":0.07229700003517792},"localbgs-corporate_update":{"message":"Faraday BGS CorporateUpdateServiceBean/CorporateUpdateWebService is unavailable","success":false,"time":0.07226400001673028},"localbgs-person":{"message":"Faraday BGS PersonWebServiceBean/PersonWebService is unavailable","success":false,"time":0.07220300001790747},"localbgs-org":{"message":"Faraday BGS OrgWebServiceBean/OrgWebService is unavailable","success":false,"time":0.07211099995765835},"localbgs-ebenefitsbenftclaim":{"message":"Faraday BGS EBenefitsBnftClaimStatusWebServiceBean/EBenefitsBnftClaimStatusWebService is unavailable","success":false,"time":0.07202100002905354},"localbgs-intenttofile":{"message":"Faraday BGS IntentToFileWebServiceBean/IntentToFileWebService is unavailable","success":false,"time":0.07186600001296028},"localbgs-trackeditem":{"message":"Faraday BGS TrackedItemService/TrackedItemService is unavailable","success":false,"time":0.07183500000974163},"benefits-documents":{"message":"Benefits Documents V1 is running","success":true,"time":0.5410760000231676},"form-526-docker-container":{"message":"Form 526 Docker Container is unavailable","success":false,"time":0.06278199999360368},"pdf-generator":{"message":"PDF Generator is unavailable","success":false,"time":0.055619999999180436}}
What areas of the site does it impact?
modules/claims_api/config/initializers/okcomputer.rb
modules/claims_api/spec/requests/metadata_spec.rb
Acceptance criteria
Requested Feedback
I added CorporateUpdateWebService (ref PR) but wondering if we should add all of the other services created to replace BGS-ext services at this point?