Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BGS-ext services from healthchecks #19587

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

mchristiansonVA
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): NO
  • Removes BGS-ext code from healthchecks

Related issue(s)

API-41368

Testing done

Output example

{"default":{"message":"Application is running","success":true,"time":3.00002284348011e-06},"database":{"message":"Schema version: 20241108144805","success":true,"time":0.08352900005411357},"mpi":{"message":"MPI is running","success":true,"time":1.0000017937272787e-05},"localbgs-claimant":{"message":"Faraday BGS ClaimantServiceBean/ClaimantWebService is unavailable","success":false,"time":0.07229700003517792},"localbgs-corporate_update":{"message":"Faraday BGS CorporateUpdateServiceBean/CorporateUpdateWebService is unavailable","success":false,"time":0.07226400001673028},"localbgs-person":{"message":"Faraday BGS PersonWebServiceBean/PersonWebService is unavailable","success":false,"time":0.07220300001790747},"localbgs-org":{"message":"Faraday BGS OrgWebServiceBean/OrgWebService is unavailable","success":false,"time":0.07211099995765835},"localbgs-ebenefitsbenftclaim":{"message":"Faraday BGS EBenefitsBnftClaimStatusWebServiceBean/EBenefitsBnftClaimStatusWebService is unavailable","success":false,"time":0.07202100002905354},"localbgs-intenttofile":{"message":"Faraday BGS IntentToFileWebServiceBean/IntentToFileWebService is unavailable","success":false,"time":0.07186600001296028},"localbgs-trackeditem":{"message":"Faraday BGS TrackedItemService/TrackedItemService is unavailable","success":false,"time":0.07183500000974163},"benefits-documents":{"message":"Benefits Documents V1 is running","success":true,"time":0.5410760000231676},"form-526-docker-container":{"message":"Form 526 Docker Container is unavailable","success":false,"time":0.06278199999360368},"pdf-generator":{"message":"PDF Generator is unavailable","success":false,"time":0.055619999999180436}}

What areas of the site does it impact?

modules/claims_api/config/initializers/okcomputer.rb
modules/claims_api/spec/requests/metadata_spec.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

I added CorporateUpdateWebService (ref PR) but wondering if we should add all of the other services created to replace BGS-ext services at this point?

@mchristiansonVA mchristiansonVA added the claimsApi modules/claims_api label Nov 22, 2024
@mchristiansonVA mchristiansonVA self-assigned this Nov 22, 2024
@mchristiansonVA mchristiansonVA requested a review from a team as a code owner November 22, 2024 21:32
@va-vfs-bot va-vfs-bot temporarily deployed to API-41368-remove-bgs-ext-okcomputer/main/main November 25, 2024 19:30 Inactive
Copy link
Contributor

@stiehlrod stiehlrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@va-vfs-bot va-vfs-bot temporarily deployed to API-41368-remove-bgs-ext-okcomputer/main/main December 2, 2024 16:40 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants