[VI-252] MAP SecurityToken duration validation #19635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramleyjl
force-pushed
the
VI-252_security_token_logs
branch
from
5baf574 to
0f749ed
Compare
va-vfs-bot
temporarily deployed
to
VI-252_security_token_logs/main/main
bramleyjl
changed the title
| @@ -66,6 +66,10 @@ def client_assertion_patient_id_type | |||
| 'icn' | |||
| end | |||
|
|
|||
| def max_token_duration | |||
| 900 | |||
There was a problem hiding this comment.
could we make this 900.seconds? just so it's clear
lib/map/security_token/service.rb
Outdated
| rescue Errors::InvalidTokenDurationError => e | ||
| raise e |
There was a problem hiding this comment.
I dont think you need to rescue and re-raise here. This should get rescued in the token method
lib/map/security_token/service.rb
Outdated
Comment on lines
60
to
63
| if response_body['expires_in'].to_i > config.max_token_duration | ||
| raise Errors::InvalidTokenDurationError, | ||
| "#{config.logging_prefix} token failed, token duration exceeds maximum" | ||
| end |
There was a problem hiding this comment.
should we move this check to a separate method? I think it would make it a bit easier to read
bramleyjl
force-pushed
the
VI-252_security_token_logs
branch
from
0f749ed to
927c0e8
Compare
github-actions
bot
added
require-backend-approval
ready-for-backend-review
test-failure
and removed
test-passing
ready-for-backend-review
labels
ericboehs
approved these changes
Dec 12, 2024
|
Scope has changed enough that I'm closing this ticket and opening a different PR here: #19907 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
900seconds are considered invalid and will result in a502 bad gatewayerror if requested through the MAP services controller.Related issue(s)
Testing done
locahost:3000/v0/map_services/chatbot/token- you should receive a 200 response & a tokenvets-api-mockdata/map/secure_token_service/token.ymlexpires_invalue to greater than 900 & re-request the token - you should receive a 502 Bad Gateway errorScreenshots
What areas of the site does it impact?
MAP STS requests
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?