Use the callback_metadata key when we send an email to a user_account #19638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
use-callback-with-emails-with-user-account/main/main
va-vfs-bot
temporarily deployed
to
use-callback-with-emails-with-user-account/main/main
va-vfs-bot
temporarily deployed
to
use-callback-with-emails-with-user-account/main/main
va-vfs-bot
temporarily deployed
to
use-callback-with-emails-with-user-account/main/main
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
rjohnson2011
requested changes
Dec 3, 2024
| @@ -127,7 +127,7 @@ | |||
| subject.send(at: time) | |||
|
|
|||
| expect(VANotify::UserAccountJob).to have_received(:perform_at).with(time, user_account.id, anything, | |||
| anything) | |||
| anything, anything, anything) | |||
There was a problem hiding this comment.
Can these variables be more specific?
rjohnson2011
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR uses the
callback_metadatakey when we send an email from Simple Forms and do NOT have an email from the form data but we do have one from theuser_account.