Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VI-740] Skipping MHV Account creation call during auth if user is authenticating from a 'custom' call #19651

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[VI-740] Skipping MHV Account creation call during auth if user is authenticating from a 'custom' call #19651

merged 1 commit into from
Dec 2, 2024

Conversation

bosawt
Copy link
Contributor

@bosawt bosawt commented Nov 27, 2024

Summary

  • This PR updates the MHV Account Creation API call during auth so that this is not called if the user is authenticating from a 'custom' call (an inbound call)

Related issue(s)

Testing done

  • Authenticated with type=custom
  • Confirmed MHV Account creation API wasn't attempted to be called

What areas of the site does it impact?

Authentication

Acceptance criteria

  • Authenticate with SSOe, type=custom, to emulate an inbound call
  • Confirm that there is not a job enqueued that attempts to call the MHV Account creation API (the name of the job is MHV::AccountCreatorJob, this job should not be enqueued during auth)

@bosawt bosawt requested a review from a team as a code owner November 27, 2024 21:06
@va-vfs-bot va-vfs-bot temporarily deployed to VI-740_mhv_do_not_call_account_creation_custom/main/main November 27, 2024 21:15 Inactive
@bosawt bosawt force-pushed the VI-740_mhv_do_not_call_account_creation_custom branch from 8c7ca24 to 2ee704c Compare November 27, 2024 21:18
bramleyjl
bramleyjl approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@bramleyjl bramleyjl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed an SSOe custom auth & confirmed that MHV Account Creation was not called in the course of AfterLoginActions performing.

@bosawt bosawt merged commit ce5a96b into master Dec 2, 2024
31 checks passed
@bosawt bosawt deleted the VI-740_mhv_do_not_call_account_creation_custom branch December 2, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bramleyjl bramleyjl bramleyjl approved these changes

@rileyanderson rileyanderson rileyanderson approved these changes

Assignees
No one assigned
Labels
omit-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bosawt @rileyanderson @bramleyjl @va-vfs-bot