Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-42887] Remove blank zipLastFour from AutoEstablishedClaim #19671

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

tycol7
Copy link
Contributor

@tycol7 tycol7 commented Dec 2, 2024

Summary

Remove blank zipLastFour from form526.veteran.changeOfAddress form_data before submission to EVSS.

Related issue(s)

API-42887

Testing done

  • New code is covered by unit tests

Screenshots

N/A

What areas of the site does it impact?

AutoEstablishedClaim model.

Acceptance criteria

  • I added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

N/A

@tycol7 tycol7 added the claimsApi modules/claims_api label Dec 2, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to tdc/remove-empty-ziplastfour/main/main December 2, 2024 18:19 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to tdc/remove-empty-ziplastfour/main/main December 2, 2024 19:22 Inactive
Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tycol7 tycol7 merged commit 805c4cc into master Dec 2, 2024
57 checks passed
@tycol7 tycol7 deleted the tdc/remove-empty-ziplastfour branch December 2, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api test-passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants