-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api 42322 extract org web service bean from local bgs #19796
base: master
Are you sure you want to change the base?
Api 42322 extract org web service bean from local bgs #19796
Conversation
…rgWebServiceBean-from-localBGS
…rgWebServiceBean-from-localBGS
…rgWebServiceBean-from-localBGS
…rgWebServiceBean-from-localBGS
@mchristiansonVA Did you check the Veteran module for usage of the org web service? @rockwellwindsor-va pointed this out to me on another PR. |
…rgWebServiceBean-from-localBGS
…rgWebServiceBean-from-localBGS
we're calling for the WSDL because of the lack of Service / Bean in the definitions file. Should be able to replace the
|
body.xpath("./*[local-name()='#{k}']")[0].content = v | ||
end | ||
|
||
make_request(endpoint: 'OrgWebServiceBean/OrgWebService', action: 'findPoaHistoryByPtcpntId', body:, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can use bean_name here for the endpoint so it's changeable in one place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can use bean_name here for the endpoint so it's changeable in one place.
Would be a nice fix but not critical to functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Related issue(s)
Testing done
What areas of the site does it impact?
POA v1 & v2 calls to BGS findPoaHistoryByPtcpntId updated to use OrgWebService
Acceptance criteria