Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api 42322 extract org web service bean from local bgs #19796

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

mchristiansonVA
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): NO
  • Extracts OrgWebService into its own file.
  • Updates User to use OrgWebService for calls to findPoaHistoryByPtcpntId
  • Updates User and POA specs.

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Tested local calls to POA v1 & v2
  • Rspec

What areas of the site does it impact?

POA v1 & v2 calls to BGS findPoaHistoryByPtcpntId updated to use OrgWebService

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@mchristiansonVA mchristiansonVA added the claimsApi modules/claims_api label Dec 9, 2024
@mchristiansonVA mchristiansonVA self-assigned this Dec 9, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to API-42322-Extract-OrgWebServiceBean-from-localBGS/main/main December 9, 2024 22:36 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-42322-Extract-OrgWebServiceBean-from-localBGS/main/main December 10, 2024 15:06 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-42322-Extract-OrgWebServiceBean-from-localBGS/main/main December 10, 2024 15:55 Inactive
@mchristiansonVA mchristiansonVA marked this pull request as ready for review December 10, 2024 16:02
@mchristiansonVA mchristiansonVA requested review from a team as code owners December 10, 2024 16:02
@stiehlrod
Copy link
Contributor

@mchristiansonVA Did you check the Veteran module for usage of the org web service? @rockwellwindsor-va pointed this out to me on another PR.

@va-vfs-bot va-vfs-bot temporarily deployed to API-42322-Extract-OrgWebServiceBean-from-localBGS/main/main December 10, 2024 20:22 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-42322-Extract-OrgWebServiceBean-from-localBGS/main/main December 11, 2024 21:03 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-42322-Extract-OrgWebServiceBean-from-localBGS/main/main December 12, 2024 14:33 Inactive
@FonzMP
Copy link
Contributor

FonzMP commented Dec 13, 2024

we're calling for the WSDL because of the lack of Service / Bean in the definitions file. Should be able to replace theOrgWebService with the below. Starts at :136

      ##
      # OrgWebServiceBean
      #
      module OrgWebServiceBean
        DEFINITION =
          Bean.new(
            path: 'OrgWebServiceBean',
            namespaces: Namespaces.new(
              target: 'http://org.services.vetsnet.vba.va.gov/',
              data: nil
            )
          )
      end

      module OrgWebService
        DEFINITION =
          Service.new(
            bean: OrgWebServiceBean::DEFINITION,
            path: 'OrgWebService'
          )
      end

@va-vfs-bot va-vfs-bot temporarily deployed to API-42322-Extract-OrgWebServiceBean-from-localBGS/main/main December 16, 2024 20:06 Inactive
body.xpath("./*[local-name()='#{k}']")[0].content = v
end

make_request(endpoint: 'OrgWebServiceBean/OrgWebService', action: 'findPoaHistoryByPtcpntId', body:,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can use bean_name here for the endpoint so it's changeable in one place.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can use bean_name here for the endpoint so it's changeable in one place.

Would be a nice fix but not critical to functionality.

Copy link
Contributor

@FonzMP FonzMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api test-passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants