Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Address V3 country_code_iso2 params #19861

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Conversation

RachalCassity
Copy link
Member

@RachalCassity RachalCassity commented Dec 12, 2024

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

VAProfile V3 Address had incorrect parameters for country_code_fips and country_code_iso2. The params were corrected with the AddressValidation docs

AddressValidationController does not permit the country_code_iso2 parameter. The country_code_iso2 params were removed from the AddressValidation service

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@RachalCassity RachalCassity requested review from a team as code owners December 12, 2024 17:53
@RachalCassity RachalCassity self-assigned this Dec 12, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to rcassity-address-bugs/main/main December 12, 2024 18:07 Inactive
@RachalCassity RachalCassity changed the title Fixed Contact Information country_code_fips and country_code_iso2 params Ensure country_code_iso2 params are present when requesting the Contact Information V2 info Dec 12, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to rcassity-address-bugs/main/main December 12, 2024 18:25 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to rcassity-address-bugs/main/main December 12, 2024 19:02 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to rcassity-address-bugs/main/main December 12, 2024 19:32 Inactive
@RachalCassity RachalCassity enabled auto-merge (squash) December 12, 2024 20:22
@RachalCassity RachalCassity changed the title Ensure country_code_iso2 params are present when requesting the Contact Information V2 info Fixed Address V3 country_code_iso2 params Dec 12, 2024
@@ -82,9 +82,9 @@ def self.build_from(body)
bad_address: body['bad_address'],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed configs found in the AddressValidation docs.

@@ -45,7 +45,6 @@
'country' => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

country_code_iso2 was removed because the AddressValidationController does not permit country_code_iso2

@@ -199,8 +199,8 @@
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added country_code_fips back to this spec

@RachalCassity RachalCassity merged commit b2d9f72 into master Dec 12, 2024
39 of 43 checks passed
@RachalCassity RachalCassity deleted the rcassity-address-bugs branch December 12, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants