-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Address V3 country_code_iso2 params #19861
Conversation
…ct Information V2 info
6c64b7e
to
e231efd
Compare
…fairs/vets-api into rcassity-address-bugs
@@ -82,9 +82,9 @@ def self.build_from(body) | |||
bad_address: body['bad_address'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed configs found in the AddressValidation docs.
@@ -45,7 +45,6 @@ | |||
'country' => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
country_code_iso2 was removed because the AddressValidationController does not permit country_code_iso2
@@ -199,8 +199,8 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added country_code_fips back to this spec
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Summary
VAProfile V3 Address had incorrect parameters for country_code_fips and country_code_iso2. The params were corrected with the AddressValidation docs
AddressValidationController does not permit the country_code_iso2 parameter. The country_code_iso2 params were removed from the AddressValidation service
Related issue(s)
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?