Added BGS\MPI ICn lookup via fileNumber #19862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelpmcdonald
added
Lighthouse
va-vfs-bot
temporarily deployed
to
API-41210_find_report_icn_to_caseflow/main/main
va-vfs-bot
temporarily deployed
to
API-41210_find_report_icn_to_caseflow/main/main
github-actions
bot
added
ready-for-backend-review
test-failure
and removed
lint-failure
test-passing
ready-for-backend-review
labels
…b.com/department-of-veterans-affairs/vets-api into API-41210_find_report_icn_to_caseflow
va-vfs-bot
temporarily deployed
to
API-41210_find_report_icn_to_caseflow/main/main
github-actions
bot
added
test-passing
ready-for-backend-review
and removed
test-failure
labels
va-vfs-bot
temporarily deployed
to
API-41210_find_report_icn_to_caseflow/main/main
ericboehs
previously approved these changes
Dec 16, 2024
kristen-brown
requested changes
Dec 16, 2024
modules/vba_documents/app/sidekiq/vba_documents/upload_processor.rb
Outdated
Show resolved
Hide resolved
…b.com/department-of-veterans-affairs/vets-api into API-41210_find_report_icn_to_caseflow
va-vfs-bot
temporarily deployed
to
API-41210_find_report_icn_to_caseflow/main/main
kristen-brown
approved these changes
Dec 17, 2024
ericboehs
approved these changes
Dec 17, 2024
derekhouck
pushed a commit
that referenced
this pull request
Dec 31, 2024
* Added BGS\MPI ICn lookup via fileNumber
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Benefits Intake API accepts PDF uploads from consumers and sends them to EMMS API for intake into various VA systems.
Recently EMMS API added a new optional ICN field we can provide in the metadata we send them along with the PDFs to provide better tracking.
This PR adds an ICN lookup. Consumer provides fileNumber(it's usually a ssn, actual fileNumber, or participant ID).
Since MPI does not have a fileNumber only lookup, we first have to look up the veteran in BGS to get their birthday, then we hit MPI and grab the veterans ICN, we send that ICN to EMMS.
No flipper flag, but one method entry point to lookup protected with catch all exception handling logging.
Related issue(s)
API-41210
Team Banana Peels, we own the modified code
Testing done
Also, extensive manual testing to make sure approach was valid
Screenshots
Note: Optional
What areas of the site does it impact?
Benefits Intake upload to EMMS API step
Acceptance criteria
Requested Feedback