Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-43408] PowerOfAttorneyRequest create Blueprint #19932

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tycol7
Copy link
Contributor

@tycol7 tycol7 commented Dec 17, 2024

WIP

Summary

  • Add Blueprinter to PowerOfAttorneyRequest create.
  • Move id and type attributes to root level.

Related issue(s)

API-43408

Testing done

  • New code is covered by unit tests
  • Observed correct response:
{
    "data": {
        "id": "ccabac92-a9e2-4349-ab99-76e89381a62c",
        "type": "power-of-attorney-request",
        "attributes": {
            "veteran": {
                "serviceNumber": "123678453",
                "serviceBranch": "ARMY",
                "address": {
                    "addressLine1": "2719 Hyperion Ave",
                    "addressLine2": "Apt 2",
                    "city": "Los Angeles",
                    "country": "USA",
                    "stateCode": "CA",
                    "zipCode": "92264",
                    "zipCodeSuffix": "0200"
                },
                "phone": {
                    "areaCode": "555",
                    "phoneNumber": "5551234"
                },
                "email": "test@test.com",
                "insuranceNumber": "1234567890"
            },
            "poa": {
                "poaCode": "003",
                "registrationNumber": "456",
                "jobTitle": "MyJob"
            },
            "recordConsent": true,
            "consentAddressChange": true,
            "consentLimits": [
                "DRUG_ABUSE",
                "SICKLE_CELL",
                "HIV",
                "ALCOHOLISM"
            ]
        }
    }
}

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@tycol7 tycol7 added the claimsApi modules/claims_api label Dec 17, 2024
@tycol7 tycol7 force-pushed the tdc/poa-blueprinter branch from 85601cb to e09c9c9 Compare December 17, 2024 19:23
@va-vfs-bot va-vfs-bot temporarily deployed to tdc/poa-blueprinter/main/main December 17, 2024 19:39 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to tdc/poa-blueprinter/main/main December 17, 2024 20:11 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to tdc/poa-blueprinter/main/main December 17, 2024 20:43 Inactive
@tycol7 tycol7 force-pushed the tdc/poa-blueprinter branch from 1ca7fce to df0c0fb Compare December 17, 2024 20:58
@va-vfs-bot va-vfs-bot temporarily deployed to tdc/poa-blueprinter/main/main December 17, 2024 21:19 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api test-passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants