Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update loofah gem to address CVE #2409

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Update loofah gem to address CVE #2409

merged 1 commit into from
Oct 31, 2018

Conversation

annaswims
Copy link
Contributor

@annaswims annaswims commented Oct 31, 2018 •
edited
Loading

CVE-2018-16468 - Loofah XSS Vulnerability

flavorjones/loofah#154

Description of change

bumped the version of loofah

Testing done

read change log
https://github.com/flavorjones/loofah/blob/master/CHANGELOG.md#223--2018-10-30

Testing planned

specs... no expected functionality changes

Applies to all PRs

  • Appropriate logging
  • Swagger docs have been updated, if applicable
  • Provide link to originating GitHub issue, or connected to it via ZenHub
  • Does not contain any sensitive information (i.e. PII/credentials/internal URLs/etc., in logging, hardcoded, or in specs)
  • Provide which alerts would indicate a problem with this functionality (if applicable)

@annaswims annaswims requested review from lihanli and U-DON October 31, 2018 03:57
@annaswims annaswims mentioned this pull request Oct 31, 2018
Merged
5 tasks
@annaswims annaswims requested review from saneshark and dhall October 31, 2018 11:30
dhall
dhall approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@dhall dhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of this :)

@annaswims annaswims merged commit 28593b3 into master Oct 31, 2018
@annaswims annaswims deleted the update_loofah branch January 14, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhall dhall dhall approved these changes

@lihanli lihanli Awaiting requested review from lihanli

@U-DON U-DON Awaiting requested review from U-DON

@saneshark saneshark Awaiting requested review from saneshark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annaswims @dhall