Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Power of Attorney Endpoints and Docs #3261

Merged
merged 58 commits into from
Sep 19, 2019
Merged

Power of Attorney Endpoints and Docs #3261

merged 58 commits into from
Sep 19, 2019

Conversation

bastosmichael
Copy link
Contributor

@bastosmichael bastosmichael commented Sep 3, 2019 •
edited
Loading

Description of change

Intended to cover tickets https://github.com/department-of-veterans-affairs/vets-contrib/issues/2972 and https://github.com/department-of-veterans-affairs/vets-contrib/issues/2969

Testing done

  • Tested Locally
  • Wrote Rspec Tests

Testing planned

  • Testing in dev-api.va.gov once deployed

Acceptance Criteria (Definition of Done)

  • Create an end point for 21-22 that allows us to submit through the controller and persist to a model the submitted payload information, the previous PoA code in the system and who did the submission.

Applies to all PRs

  • Appropriate logging
  • Swagger docs have been updated, if applicable
  • Provide link to originating GitHub issue, or connected to it via ZenHub
  • Does not contain any sensitive information (i.e. PII/credentials/internal URLs/etc., in logging, hardcoded, or in specs)
  • Provide which alerts would indicate a problem with this functionality (if applicable)

@bastosmichael bastosmichael marked this pull request as ready for review September 10, 2019 14:45
@bastosmichael bastosmichael requested review from a team as code owners September 10, 2019 14:45
@va-vfs-bot va-vfs-bot temporarily deployed to bastosmichael/21-22/master September 17, 2019 22:47 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to bastosmichael/21-22/master September 18, 2019 14:35 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to bastosmichael/21-22/master September 18, 2019 15:30 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to bastosmichael/21-22/master September 18, 2019 15:38 Inactive
@bastosmichael bastosmichael mentioned this pull request Sep 18, 2019
Merged
5 tasks
@va-vfs-bot va-vfs-bot temporarily deployed to bastosmichael/21-22/master September 18, 2019 18:07 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to bastosmichael/21-22/master September 19, 2019 14:20 Inactive
charleystran
charleystran approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@charleystran charleystran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bastosmichael bastosmichael merged commit d9bc815 into master Sep 19, 2019
@johnpaulashenfelter johnpaulashenfelter deleted the bastosmichael/21-22 branch January 20, 2020 14:40
@bastosmichael bastosmichael restored the bastosmichael/21-22 branch January 27, 2020 13:44
@johnpaulashenfelter johnpaulashenfelter deleted the bastosmichael/21-22 branch February 3, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jholton jholton jholton left review comments

@charleystran charleystran charleystran approved these changes

@ATeal ATeal Awaiting requested review from ATeal

@dhall dhall Awaiting requested review from dhall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bastosmichael @charleystran @jholton @va-vfs-bot