-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
509 evss backend sentry error to info #3297
Conversation
I missed the first PR that this one builds off of. I would have said this then: I think should move logic that changes an error's 'level' into a Sentry processor. We already have one that sets certain exceptions to We should keep this type of logic in one place (processors, IMO). Otherwise we are asking for a situation in the future where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this might live better in EVSS middleware.
@jholton just FYI - we are going to merge this change for now to supress the particular EVSS 503 response, but we will be working to refactor our overall error handling in order to leverage a sentry processor/middleware pattern. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this for now!
Description of change
This change reduces Sentry noise by logging the EVSSBackendServiceError with a level of info instead of error, no longer creating a sentry error alert. After discussion, triggering a sentry alert is not necessary.
Testing done
Spec tests run & pass
Sentry logging remains the same for other error logging
Acceptance Criteria (Definition of Done)
Applies to all PRs